add new suite test

Signed-off-by: sivchari <[email protected]>

pkg/controller/controllerutil/controllerutil.go

@@ -183,17 +183,17 @@ func HasControllerReference(object metav1.Object) bool {
 
 // HasOwnerReference returns true if the owners list contains an owner reference
 // that matches the object's group, kind, and name.
-func HasOwnerReference(ownerRefs []metav1.OwnerReference, obj client.Object, scheme *runtime.Scheme) bool {
+func HasOwnerReference(ownerRefs []metav1.OwnerReference, obj client.Object, scheme *runtime.Scheme) (bool, error) {
 	gvk, err := apiutil.GVKForObject(obj, scheme)
 	if err != nil {
-		return false
+		return false, err
 	}
 	idx := indexOwnerRef(ownerRefs, metav1.OwnerReference{
 		APIVersion: gvk.GroupVersion().String(),
 		Name:       obj.GetName(),
 		Kind:       gvk.Kind,
 	})
-	return idx != -1
+	return idx != -1, nil
 }
 
 // RemoveControllerReference removes an owner reference where the controller

pkg/controller/controllerutil/controllerutil_test.go

@@ -957,6 +957,42 @@ var _ = Describe("Controllerutil", func() {
 				Expect(controllerutil.ContainsFinalizer(deploy, testFinalizer)).To(BeFalse())
 			})
 		})
+
+		Describe("HasOwnerReference", func() {
+			It("should return true if the object has the owner reference", func() {
+				rs := &appsv1.ReplicaSet{
+					ObjectMeta: metav1.ObjectMeta{Name: "foo", UID: "foo-uid"},
+				}
+				dep := &extensionsv1beta1.Deployment{
+					ObjectMeta: metav1.ObjectMeta{Name: "foo", UID: "foo-uid"},
+				}
+				Expect(controllerutil.SetOwnerReference(dep, rs, scheme.Scheme)).ToNot(HaveOccurred())
+
+				b, err := controllerutil.HasOwnerReference(dep.GetOwnerReferences(), rs, scheme.Scheme)
+				Expect(err).NotTo(HaveOccurred())
+				Expect(b).To(BeTrue())
+			})
+
+			It("should return false if the object does not have the owner reference", func() {
+				rs := &appsv1.ReplicaSet{
+					ObjectMeta: metav1.ObjectMeta{Name: "foo", UID: "foo-uid"},
+				}
+				dep := &extensionsv1beta1.Deployment{
+					ObjectMeta: metav1.ObjectMeta{Name: "foo", UID: "foo-uid"},
+				}
+				b, err := controllerutil.HasOwnerReference(dep.GetOwnerReferences(), rs, scheme.Scheme)
+				Expect(err).NotTo(HaveOccurred())
+				Expect(b).To(BeFalse())
+			})
+
+			It("should return error if the object can not create group-version-kind", func() {
+				rs := &appsv1.ReplicaSet{}
+				dep := &errMetaObj{}
+				b, err := controllerutil.HasOwnerReference(dep.GetOwnerReferences(), rs, runtime.NewScheme())
+				Expect(err).To(HaveOccurred())
+				Expect(b).To(BeFalse())
+			})
+		})
 	})
 })