Copy object before modifying it

Otherwise you can get races when getting and listing simultaneously
kubernetes-sigs · Apr 3, 2019 · 7f16f2b · 7f16f2b
1 parent bab2dad
commit 7f16f2b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/cache/internal/cache_reader.go b/pkg/cache/internal/cache_reader.go
@@ -125,8 +125,9 @@ func (c *CacheReader) List(_ context.Context, out runtime.Object, opts ...client
 		if !isObj {
 			return fmt.Errorf("cache contained %T, which is not an Object", obj)
 		}
-		obj.GetObjectKind().SetGroupVersionKind(c.groupVersionKind)
-		runtimeObjs = append(runtimeObjs, obj)
+		outObj := obj.DeepCopyObject()
+		outObj.GetObjectKind().SetGroupVersionKind(c.groupVersionKind)
+		runtimeObjs = append(runtimeObjs, outObj)
 	}
 	filteredItems, err := objectutil.FilterWithLabels(runtimeObjs, labelSel)
 	if err != nil {