Merge pull request #1076 from jiachengxu/webhook-port

⚠️ Change default webhook port to 9443

pkg/builder/builder_suite_test.go

@@ -74,7 +74,7 @@ var _ = AfterSuite(func() {
 	metrics.DefaultBindAddress = ":8080"
 
 	// Change the webhook.DefaultPort back to the original default.
-	webhook.DefaultPort = 443
+	webhook.DefaultPort = 9443
 })
 
 func addCRDToEnvironment(env *envtest.Environment, gvks ...schema.GroupVersionKind) {

pkg/manager/manager_test.go

@@ -135,14 +135,14 @@ var _ = Describe("manger.Manager", func() {
 
 		It("should lazily initialize a webhook server if needed", func(done Done) {
 			By("creating a manager with options")
-			m, err := New(cfg, Options{Port: 9443, Host: "foo.com"})
+			m, err := New(cfg, Options{Port: 9440, Host: "foo.com"})
 			Expect(err).NotTo(HaveOccurred())
 			Expect(m).NotTo(BeNil())
 
 			By("checking options are passed to the webhook server")
 			svr := m.GetWebhookServer()
 			Expect(svr).NotTo(BeNil())
-			Expect(svr.Port).To(Equal(9443))
+			Expect(svr.Port).To(Equal(9440))
 			Expect(svr.Host).To(Equal("foo.com"))
 
 			close(done)

pkg/webhook/server.go

@@ -37,7 +37,7 @@ import (
 )
 
 // DefaultPort is the default port that the webhook server serves.
-var DefaultPort = 443
+var DefaultPort = 9443
 
 // Server is an admission webhook server that can serve traffic and
 // generates related k8s resources for deploying.
@@ -47,7 +47,7 @@ type Server struct {
 	Host string
 
 	// Port is the port number that the server will serve.
-	// It will be defaulted to 443 if unspecified.
+	// It will be defaulted to 9443 if unspecified.
 	Port int
 
 	// CertDir is the directory that contains the server key and certificate. The