Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Add support to read webhook configurations from files for WebhookInstallOptions #1080

Merged
merged 1 commit into from
Aug 5, 2020
Merged

⚠️ Add support to read webhook configurations from files for WebhookInstallOptions #1080

merged 1 commit into from
Aug 5, 2020

Conversation

jiachengxu
Copy link
Contributor

Fixes #1019
This PR adds support to read webhook configurations from files for WebhookInstallOptions

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jiachengxu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2020
hasbro17
hasbro17 reviewed Jul 29, 2020
View reviewed changes
pkg/envtest/webhook.go
DirectoryPaths []string
// Paths is a list of paths to the directories or files containing the mutating or validating webhooks yaml or json configs.
Paths []string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming DirectoryPaths to Paths would be a breaking change right?
If so, we should probably mark this commit with a ⚠️ prefix.

Unless we want to avoid that and add a separate field e.g FilePaths.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you are right, it is a breaking change.

I prefer to not add FilePaths since I would like to keep it consistent with CRDInstallOptions.

WDYT? @vincepri @DirectXMan12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for consistency, we can delay this change until v0.7

@jiachengxu jiachengxu changed the title ✨ Add support to read webhook configurations from files for WebhookInstallOptions ⚠️ Add support to read webhook configurations from files for WebhookInstallOptions Jul 29, 2020
@vincepri
Copy link
Member

/milestone v0.7.x

@k8s-ci-robot k8s-ci-robot added this to the v0.7.x milestone Jul 29, 2020
@alvaroaleman
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 30, 2020
@jiachengxu
Copy link
Contributor Author

/retest

@jiachengxu
Copy link
Contributor Author

/test pull-controller-runtime-apidiff-master

@k8s-ci-robot
Copy link
Contributor

@jiachengxu: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-controller-runtime-apidiff-master 45bd578 link /test pull-controller-runtime-apidiff-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jiachengxu
Copy link
Contributor Author

@alvaroaleman @vincepri How can I make the pull-controller-runtime-apidiff-master happy? This PR does introduce breaking changes :).

@alvaroaleman
Copy link
Member

You can't, but having it pass is not mandatory for merges, its more of an informational thing.
/approve
/assign @vincepri

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, jiachengxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
vincepri
vincepri approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 420cd15 into kubernetes-sigs:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 left review comments

@vincepri vincepri vincepri approved these changes

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.x
Development

Successfully merging this pull request may close these issues.

webhookinstalloptions should support individual files
5 participants
@jiachengxu @k8s-ci-robot @vincepri @alvaroaleman @hasbro17