-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix log depth for DelegatingLogSink #1975
🐛 Fix log depth for DelegatingLogSink #1975
Conversation
1da8d8c
to
9940425
Compare
It looks like the linter is broken |
/assign @alvaroaleman |
9940425
to
ca3b341
Compare
looks like golangci-lint is too old |
I think it should pass after #1976 |
@alculquicondor can you rebase? It doesn't look like github actions merges into the base prior to reading the job config, I re-ran the action and it still uses the old golang-ci lint version: https://github.com/kubernetes-sigs/controller-runtime/runs/7795811041?check_suite_focus=true#step:3:16 |
ca3b341
to
797c6b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1737
Adds a depth of 1 to the DelegatingLogSink sink, instead of a global depth to the zapr sink.
This global depth is problematic because it doesn't apply to loggers obtained with
WithName
orWithValues
.Notes for reviewer
To see this fix in action (and the bug before this fix), go to
examples/scratch-env/main.go
and set Development mode to false.