Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 stop using hardcoded temp dir #530

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Jul 22, 2019

We now use https://golang.org/pkg/os/#TempDir to get the os specific
temp dir. Otherwise, it won't work for Windows users.
We also switch to use the os-aware Join method.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot requested review from droot and pwittrock July 22, 2019 23:27
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2019
@mengqiy mengqiy requested a review from DirectXMan12 July 22, 2019 23:27
We now use https://golang.org/pkg/os/#TempDir to get the os specific
temp dir. Otherwise, it won't work for Windows users.
@Azadehkhojandi
Copy link

Thanks @mengqiy :) as you suggested issue #531 created

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit f770dcb into kubernetes-sigs:master Jul 24, 2019
@mengqiy mengqiy deleted the tmpdir branch August 28, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants