webhook generation hardcodes name and namespace

[ellistarn]

controller-tools/pkg/webhook/parser.go

Line 243 in 9a9db70

Name: "webhook-service",

I'd like this to be configurable so that I don't have to use Kustomize to add prefixes.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ellistarn]

@DirectXMan12 any thoughts here?

[davidxia]

I run my webhook in a different namespace than system so also need to customize the namespace.

[davidxia]

Looks like the [Mutating|Validating]WebhookConfigurations' name itself is also hardcoded. I also need to customize this.

I need to customize these because if I deploy two different controllers to the same cluster, I can't use controller-gen's generated files without modification since the [Mutating|Validating]WebhookConfigurations' own names and that of their .webhooks[].clientConfig.name and .webhooks[].clientConfig.name conflict with each other.

[sbueringer]

/reopen
/lifecycle frozen

[k8s-ci-robot]

@sbueringer: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/remove-lifecycle rotten