-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠ Bump github.com/gobuffalo/flect from 0.3.0 to 1.0.2 #804
Conversation
@@ -33,6 +33,7 @@ type ZooSpec struct { | |||
} | |||
type ZooStatus struct{} | |||
|
|||
// +kubebuilder:resource:path=zooes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without overwriting the plural here the new flect version would generate the plural "zoo"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the plural zoos
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what flect changed. They are now generating zoos instead of zooes.
I could have either changed the test file or pinned the path. I picked pinning the path/plural.
I'll change the test file now instead
/assign @vincepri @alvaroaleman Not sure if there is a better way to deal with the breaking change in flect. |
9e9f064
to
4381386
Compare
@vincepri done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR bumps flect to 1.0.2
Please be aware that the pluarlize logic in flect changed
Links: