-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch away from Docker Hub to avoid rate limits #1053
Switch away from Docker Hub to avoid rate limits #1053
Conversation
@AkihiroSuda: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CI failure seems irrelevant
https://github.com/kubernetes-sigs/cri-tools/actions/runs/3819000352/jobs/6496253517 Seems to have been already reported in cri-o/cri-o#6289 (comment) |
/lgtm cri-o issues will be sorted out async, I see no reason to block on this for now |
Fix issue 1052 Signed-off-by: Akihiro Suda <[email protected]>
7e91e4b
to
3a981a9
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -34,19 +34,22 @@ import ( | |||
|
|||
const ( | |||
defaultImageBenchmarkTimeoutSeconds = 10 | |||
|
|||
// defaultImageListingPrefix is for avoiding Docker Hub's rate limit | |||
defaultImageListingPrefix = "public.ecr.aws/docker/library/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, we should move those images to k8s.grc.io / registry.k8s.io.
What type of PR is this?
/kind flake (?)
What this PR does / why we need it:
To avoid Docker Hub rate limits
Which issue(s) this PR fixes:
Fixes #1052
Special notes for your reviewer:
Does this PR introduce a user-facing change?