Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch away from Docker Hub to avoid rate limits #1053

Merged

Conversation

AkihiroSuda
Copy link
Member

What type of PR is this?

/kind flake (?)

What this PR does / why we need it:

To avoid Docker Hub rate limits

Which issue(s) this PR fixes:

Fixes #1052

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Switch away from Docker Hub to avoid rate limits

@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Jan 1, 2023
@k8s-ci-robot
Copy link
Contributor

@AkihiroSuda: The label(s) kind/(?) cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind flake (?)

What this PR does / why we need it:

To avoid Docker Hub rate limits

Which issue(s) this PR fixes:

Fixes #1052

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Switch away from Docker Hub to avoid rate limits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 1, 2023
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jan 1, 2023

CI failure seems irrelevant

Run curl https://raw.githubusercontent.com/cri-o/cri-o/main/scripts/get | sudo bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  [8](https://github.com/kubernetes-sigs/cri-tools/actions/runs/3819000352/jobs/6496253517#step:8:9)566  100  8566    0     0  60323      0 --:--:-- --:--:-- --:--:-- 60323
Welcome to the CRI-O install script!
No architecture provided, using: amd64
Checking if all commands are available: curl jq tar
Searching for latest version via marker file
Found latest version 214b77367c48acd75a08610ac8d0[9](https://github.com/kubernetes-sigs/cri-tools/actions/runs/3819000352/jobs/6496253517#step:8:10)41540347691
Downloading https://storage.googleapis.com/cri-o/artifacts/cri-o.amd64.214b77367c48acd75a086[10](https://github.com/kubernetes-sigs/cri-tools/actions/runs/3819000352/jobs/6496253517#step:8:11)ac8d0941540347691.tar.gz to /tmp/tmp.A[12](https://github.com/kubernetes-sigs/cri-tools/actions/runs/3819000352/jobs/6496253517#step:8:13)EyjyRYX
/tmp/tmp.A12EyjyRYX ~/work/cri-tools/cri-tools
Installing CRI-O
+ install -d -m 755 /etc/cni/net.d
+ install -D -m 755 -t /opt/cni/bin cni-plugins/bandwidth cni-plugins/bridge cni-plugins/dhcp cni-plugins/firewall cni-plugins/host-device cni-plugins/host-local cni-plugins/ipvlan cni-plugins/loopback cni-plugins/macvlan cni-plugins/portmap cni-plugins/ptp cni-plugins/sbr cni-plugins/static cni-plugins/tuning cni-plugins/vlan cni-plugins/vrf
+ install -D -m 644 -t /etc/cni/net.d contrib/10-crio-bridge.conflist
install: cannot stat 'contrib/10-crio-bridge.conflist': No such file or directory
+ rm -rf -- /tmp/tmp.A12EyjyRYX
Error: Process completed with exit code 1.

https://github.com/kubernetes-sigs/cri-tools/actions/runs/3819000352/jobs/6496253517

Seems to have been already reported in cri-o/cri-o#6289 (comment)

@haircommander
Copy link
Contributor

/lgtm

cri-o issues will be sorted out async, I see no reason to block on this for now

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
Fix issue 1052

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the switch-away-from-docker-hub branch from 7e91e4b to 3a981a9 Compare January 3, 2023 22:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@@ -34,19 +34,22 @@ import (

const (
defaultImageBenchmarkTimeoutSeconds = 10

// defaultImageListingPrefix is for avoiding Docker Hub's rate limit
defaultImageListingPrefix = "public.ecr.aws/docker/library/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we should move those images to k8s.grc.io / registry.k8s.io.

@k8s-ci-robot k8s-ci-robot merged commit d885c81 into kubernetes-sigs:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch away from Docker Hub to avoid rate limits
5 participants