-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated self signed certs should be TLS secrets #88
Generated self signed certs should be TLS secrets #88
Conversation
Currently the generated Opaque secret may not be supported by all Ingress controllers. Rather than making an Opaque secret that contains the relevant data by convention, explicilty create a TLS secret to remove ambiguity. Signed-off-by: Sunjay Bhatia <[email protected]>
Welcome @sunjayBhatia! |
Hi @sunjayBhatia. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/assign @bowei |
@bowei have you gotten a chance to review this? |
@sunjayBhatia I don't have approval permissions :( |
This is needed so we can get Contour running Ingress conformance in CI |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently the generated Opaque secret may not be supported by all
Ingress controllers. Rather than making an Opaque secret that contains
the relevant data by convention, explicilty create a TLS secret to
remove ambiguity.