-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added notifications for openapi3 provider #178
added notifications for openapi3 provider #178
Conversation
Hi @Devaansh-Kumar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
eead0b3
to
fbdcf6f
Compare
fbdcf6f
to
209e375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Devaansh-Kumar! You just need to rebase, then we are good to go :)
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Devaansh-Kumar, mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
209e375
to
72546cb
Compare
@mlavacca I have rebased the branch. PR is ready to merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
/lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds notifications for conversion of OpenAPI3 provider
Which issue(s) this PR fixes:
This pull request addresses part of the issue described in #131
Does this PR introduce a user-facing change?:
/cc @mlavacca @LiorLieberman