[WIP] Support remote podman #2235

afrittoli · 2021-05-07T15:21:51Z

Gather info about the provider using podman info instead of
looking on the host directly. This allows starting a cluster
when the host is remote, for instance running in a VM on
a MacOS or Windows host.

Not all the info available via docker info is available in
podman info, so logging a warning when using podman.

Signed-off-by: Andrea Frittoli [email protected]

potential fix for white space in source path

make kindnetd tolerate everything

don't allow _ in cluster names

Gather info about the provider using `podman info` instead of looking on the host directly. This allows starting a cluster when the host is remote, for instance running in a VM on a MacOS or Windows host. Not all the info available via `docker info` is available in `podman info`, so logging a warning when using podman. Signed-off-by: Andrea Frittoli <[email protected]>

k8s-ci-robot · 2021-05-07T15:21:59Z

Welcome @afrittoli!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-05-07T15:21:59Z

Hi @afrittoli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-05-07T15:21:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afrittoli
To complete the pull request process, please assign bentheelder after the PR has been reviewed.
You can assign the PR to them by writing /assign @bentheelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

aojea · 2021-05-07T16:18:57Z

pkg/cluster/internal/providers/podman/provider.go

-	info := &providers.ProviderInfo{
-		Rootless: euid != 0,
-	}
-	if _, err := os.Stat("/sys/fs/cgroup/cgroup.controllers"); err == nil {


and .... do we stop handling the local podman case?

aojea · 2021-05-07T16:20:02Z

is there a way to know if podman is working in remote or local mode?
I rather prefer to branch on that that removing current code

aojea · 2021-05-07T16:28:42Z

pkg/cluster/internal/providers/podman/provider.go

-	info := &providers.ProviderInfo{
-		Rootless: euid != 0,
-	}
-	if _, err := os.Stat("/sys/fs/cgroup/cgroup.controllers"); err == nil {


maybe, we just need to skip this check if we can detect is a remote podman

if !podman_remote() && _, err := os.Stat("/sys/fs/cgroup/cgroup.controllers"); err == nil {

let me summon the expert,
@vrothberg can I know from the podman cli if is running remote or local?

Not yet but I opened containers/podman#10289. @baude, do you know a workaround?

@afrittoli can we try with this approach?
containers/podman#10289 (comment)
something like

// podman_remote returns true if podman is using a remote client // xref: https://github.com/containers/podman/issues/10289 func podman_remote() bool{ ... check https://github.com/containers/podman/issues/10289#issuecomment-838302394 ... }

BenTheElder · 2021-05-14T07:10:33Z

This change needs to be compatible with older podman versions.

I suspect instead of trying to detect if podman is remote or not it needs to check the podman version anyhow before selecting the format string to request, since go text templates explode on unknown fields.

aojea · 2021-05-14T07:46:53Z

This change needs to be compatible with older podman versions.

I suspect instead of trying to detect if podman is remote or not it needs to check the podman version anyhow before selecting the format string to request, since go text templates explode on unknown fields.

?

if _, err = os.exec(podman --remote info); err != nil {
 podman is local
}

BenTheElder · 2021-05-18T04:59:38Z

I mean the fields available to the format string depend on the podman version. So we should just read the podman version and if it's new enough we request the new fields and if not we collect the other fields from podman and the rest from reading local as we already support?

You don't need to check if it's local or not, either it's new enough to get this info for remote and we do that, or it's too old and we should still get the info for local. That's purely based on version.

afrittoli · 2021-05-18T10:30:42Z

I mean the fields available to the format string depend on the podman version. So we should just read the podman version and if it's new enough we request the new fields and if not we collect the other fields from podman and the rest from reading local as we already support?

You don't need to check if it's local or not, either it's new enough to get this info for remote and we do that, or it's too old and we should still get the info for local. That's purely based on version.

If we want to support older versions of podman we do indeed check the version.
The alternative could be - since support is experimental anyways - to only support newer versions. I suspect that might break someone's workflow if they upgrade to the latest kind, but given the experimental tag on the feature, it feel like it would be acceptable to require a podman upgrade along with a kind upgrade?
In any case I'm happy to oblige is the kind team prefers to continue supporting the older versions of podman.

In terms of local vs. remote, the podman info command does not provide all the info that kind expects. It is possible to work with the info only (like I've done in this PR), but we could still detect the local case and collect the extra info there.

To sum up, based on the various comments, my proposal would be to:

detect podman version
parse the output of podman info according to the version
detect if running local of remote
if local collect the info not available from the podman info command from the local system
if not enough info is available to run, fail with a specific error message

Does this make sense?
This week I have no bandwidth to work on this, but I'd be happy to come back to it next week.

aojea · 2021-05-18T13:25:15Z

podman info will provide the "remote" info, it has merged in master containers/podman#10300

I honestly will not try to support older podman versions, we have too many if branches already and the remote case seems relatively new

k8s-ci-robot · 2021-05-25T01:02:48Z

@afrittoli: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BenTheElder · 2021-06-10T18:40:43Z

I would suggest a slightly more specific order:

detect podman version (and error if too old due to difficult to deal with bugs)
collect as much info as we can for the podman version, including an attempt to detect local vs remote
if we do not detect remote, assume local
if we are local and do not have enough info, detect from local host details (probe vfs etc.)

@aojea I think time has shown that we will need to switch on the version anyhow as we cannot depend on format structs to be stable. We already do this for e.g. port mapping.

aojea · 2021-06-10T19:58:36Z

I would suggest a slightly more specific order:

detect podman version (and error if too old due to difficult to deal with bugs)

THIS ^^^

collect as much info as we can for the podman version, including an attempt to detect local vs remote

if we do not detect remote, assume local

if we are local and do not have enough info, detect from local host details (probe vfs etc.)

@aojea I think time has shown that we will need to switch on the version anyhow as we cannot depend on format structs to be stable. We already do this for e.g. port mapping.

sounds great

BenTheElder · 2022-10-06T21:04:56Z

Does anyone know if this general approach is still required? I think podman has made some improvements here 🤞

afrittoli · 2022-10-06T22:08:35Z

I tried recently kind with podman on an M1 Mac and it all worked well, so this can be closed now.
I'm sorry o never followed up on this PR.

BenTheElder · 2022-10-07T00:29:04Z

not at all, thank you!

k8s-ci-robot and others added 6 commits April 27, 2021 17:02

Merge pull request kubernetes-sigs#2215 from jason-kane/spaces_in_path

f25f1ae

potential fix for white space in source path

make kindnetd tolerate everything

b782a92

don't allow _ in cluster names

7634cf4

Merge pull request kubernetes-sigs#2225 from BenTheElder/tolerance

e223bfb

make kindnetd tolerate everything

Merge pull request kubernetes-sigs#2226 from BenTheElder/no_

58bdc4e

don't allow _ in cluster names

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2021

k8s-ci-robot requested review from amwat and krzyzacy May 7, 2021 15:21

k8s-ci-robot added area/provider/docker Issues or PRs related to docker area/provider/podman Issues or PRs related to podman size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2021

afrittoli mentioned this pull request May 7, 2021

support remote podman #2233

Open

aojea reviewed May 7, 2021

View reviewed changes

vrothberg mentioned this pull request May 10, 2021

podman info - field to check whether it's a remote client containers/podman#10289

Closed

aojea mentioned this pull request May 18, 2021

Fix podman getSubnets() #2257

Merged

BenTheElder force-pushed the main branch from 6d52a34 to 36f229f Compare May 18, 2021 19:51

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2021

BenTheElder mentioned this pull request Jul 23, 2021

Error Starting Control Plane w/ Podman on Fedora 33 #2213

Closed

afrittoli closed this Oct 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Support remote podman #2235

[WIP] Support remote podman #2235

afrittoli commented May 7, 2021

k8s-ci-robot commented May 7, 2021

k8s-ci-robot commented May 7, 2021

k8s-ci-robot commented May 7, 2021

aojea May 7, 2021

aojea commented May 7, 2021

aojea May 7, 2021 •

edited

Loading

aojea May 7, 2021

vrothberg May 10, 2021

aojea May 11, 2021

BenTheElder commented May 14, 2021

aojea commented May 14, 2021

BenTheElder commented May 18, 2021

afrittoli commented May 18, 2021

aojea commented May 18, 2021

k8s-ci-robot commented May 25, 2021

BenTheElder commented Jun 10, 2021

aojea commented Jun 10, 2021

BenTheElder commented Oct 6, 2022

afrittoli commented Oct 6, 2022

BenTheElder commented Oct 7, 2022

[WIP] Support remote podman #2235

[WIP] Support remote podman #2235

Conversation

afrittoli commented May 7, 2021

k8s-ci-robot commented May 7, 2021

k8s-ci-robot commented May 7, 2021

k8s-ci-robot commented May 7, 2021

aojea May 7, 2021

Choose a reason for hiding this comment

aojea commented May 7, 2021

aojea May 7, 2021 • edited Loading

Choose a reason for hiding this comment

aojea May 7, 2021

Choose a reason for hiding this comment

vrothberg May 10, 2021

Choose a reason for hiding this comment

aojea May 11, 2021

Choose a reason for hiding this comment

BenTheElder commented May 14, 2021

aojea commented May 14, 2021

BenTheElder commented May 18, 2021

afrittoli commented May 18, 2021

aojea commented May 18, 2021

k8s-ci-robot commented May 25, 2021

BenTheElder commented Jun 10, 2021

aojea commented Jun 10, 2021

BenTheElder commented Oct 6, 2022

afrittoli commented Oct 6, 2022

BenTheElder commented Oct 7, 2022

aojea May 7, 2021 •

edited

Loading