Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exclude-from-external-load-balancers from single node clusters #3507

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Remove exclude-from-external-load-balancers from single node clusters #3507

merged 1 commit into from
Feb 6, 2024

Conversation

howardjohn
Copy link
Contributor

Part of #3506

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2024
neolit123
neolit123 reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
we should probably mention this in the kubeadm "create a cluster" page too.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@aojea
Copy link
Contributor

aojea commented Feb 6, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@ericvn ericvn mentioned this pull request Feb 6, 2024
Merged
@howardjohn
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d81fdf6 into kubernetes-sigs:main Feb 6, 2024
27 checks passed
BenTheElder
BenTheElder reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming: this was added in 1.21? so this is a no-op for really old unsupported clusters and not worth worrying about version checks.

thanks! LGTM

@BenTheElder
Copy link
Member

we should probably mention this in the kubeadm "create a cluster" page too.

Agreed, do you prefer to track that sort of thing at k/website?

@neolit123
Copy link
Member

we should probably mention this in the kubeadm "create a cluster" page too.

Agreed, do you prefer to track that sort of thing at k/website?

i can log a new k/website ticket.

@neolit123 neolit123 mentioned this pull request Feb 6, 2024
Closed
@BenTheElder
Copy link
Member

[also confirming for next time, thanks!]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@neolit123 neolit123 neolit123 left review comments

@aojea aojea Awaiting requested review from aojea

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@howardjohn @aojea @k8s-ci-robot @BenTheElder @neolit123