always build kubernetes for linux #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
also likely fixes #409 |
BenTheElder
requested review from
neolit123 and
amwat
and removed request for
krzyzacy
BenTheElder
added
priority/critical-urgent
neolit123
reviewed
Mar 27, 2019
| @@ -86,6 +87,10 @@ func (b *DockerBuildBits) Build() error { | |||
| return buildVersionFile(b.kubeRoot) | |||
| } | |||
|
|
|||
| func dockerBuildOsAndArch() string { | |||
There was a problem hiding this comment.
wonder if Os will pass golint.
other than that LGTM.
k8s-ci-robot
added
the
lgtm
|
can confirm this fixes mac with |
stg-0
pushed a commit
to stg-0/kind
that referenced
this pull request
Feb 6, 2024
* version v0.18.0-alpha * update docs for v0.17.0 * fix kind version in readme * comments-update-buildcontext * Added helm s3 plugin * added helm s3 support * chart version rollback --------- Co-authored-by: Benjamin Elder <[email protected]> Co-authored-by: Daman <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/kubernetes-sigs/kind/pull/358/files#r269746243
kind only supports linux "nodes" currently, we can just use the host arch, but we need to build for linux even on mac 🙃