Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Bump Helm version to 2.16.3 in download-binaries script #1200

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Bump Helm version to 2.16.3 in download-binaries script #1200

merged 1 commit into from
Mar 9, 2020

Conversation

tcordeu
Copy link
Contributor

@tcordeu tcordeu commented Mar 8, 2020

The current version installed in the script (2.14.0) produces the following error when executing helm init: Error: error installing: the server could not find the requested resource. This is due to an incompatibility with clusters with versions 1.16.0+, found on helm/helm#6374.
To fix this, the Helm version is bumped to 2.16.3.

@tcordeu
Bump Helm version to 2.16.3
ad3db1a 
This will fix the incompatibility found on the `download-binaries.sh` script
for clusters with versions 1.16.0+.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @tcordeu!

It looks like this is your first PR to kubernetes-sigs/kubefed 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubefed has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2020
@tcordeu
Copy link
Contributor Author

tcordeu commented Mar 8, 2020

/assign @xunpan

hectorj2f
hectorj2f approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xunpan
Copy link
Contributor

xunpan commented Mar 9, 2020

Thank your for fixing it.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcordeu, xunpan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit be4d6ec into kubernetes-retired:master Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hectorj2f hectorj2f hectorj2f approved these changes

@font font Awaiting requested review from font

@shashidharatd shashidharatd Awaiting requested review from shashidharatd

Assignees

@xunpan xunpan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcordeu @k8s-ci-robot @xunpan @hectorj2f