This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
added blank import to ensure correct workqueue metric registration #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
hectorj2f
approved these changes
Mar 29, 2021
|
/approve |
k8s-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cebernardi, hectorj2f, makkes, mars1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
we're facing (as described here: #1386 and #1372) a racing condition on workqueue metrics registration, between
what we want is
sigs.k8s.io/controller-runtime/pkg/metricsto get registered first, but both of:have a dependency from
k8s.io/apiserver/pkg/server, that is bringingk8s.io/component-base/metrics/prometheus/workqueueinto the picture (and it gets initialized beforesigs.k8s.io/controller-runtime/pkg/metricsthis PR (#1386) solved the issue for the
controller-managerexecutable produced withmake build, but it doesn't solve it for the singlehyperfedexecutable produced withmake containeras the compilation entrypoint is different (cmd/controller-manager/main.govscmd/hyperfed/main.go)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1386
Special notes for your reviewer:
I'm not sure if worth it to uniform the output between
make containerandmake build, so that we produce the same executable (hyperfed) on both targets.. please let me know your thoughts