Adding labels only to .metadata.labels

[mikebryant]

I'd like to be able to add labels to the metadata of all objects, without them being part of the selectors.

One use case would be in our deployment pipeline, adding a label of the current git commit hash, so we can easily see which pipeline actually ran, trace back issues, stuff like that.

Currently commonLabels applies to selectors as well, which makes it unsuitable (As we don't want to force a rollout of all Deployments on every change, for example)

Is this something kustomize can/should support? Presumably using a different field name to commonLabels.

[Liujingfang1]

We will consider supporting this use case when design #91. It should provide an approach for users to add or remove different fields that they want to kustomize by transformers.

[Liujingfang1]

@mikebryant I'm thinking if annotations work for this case. Any ideas?

[mikebryant]

@Liujingfang1 I think that would work for the use-case I mentioned.

[Benjamintf1]

I don't think that would work for our use-case.

Specifically, we are deploying based on some labels, this includes a common label that is un-applied via patch from specific resources(to prevent from deleting certain resources).

[mylokin]

Supporting this kind of functionality would be really neat. I was going to implement dangling resources cleanup (that were left after prev. deployments) using commonLabels, but found this to be impossible because labels are propagated into selectors.

[jbrette]

@mylokin @Benjamintf1 @mikebryant

Please have a look at:

• KEP: Kustomize FieldSpec skip
• PR: Skip kustomize transformers for paths
• The PR seems to address the issue as demonstrated here

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[sebastiansirch]

Just in case someone is looking for a workaround: Here is an example of a transformer to add labels only to the metadata block. https://github.com/viadee/kustomize-examples/tree/master/overlays/custom-metadata-labels

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.