migrate build annotations to internal prefix #4074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/hold This will need to be rebased after #4061. |
k8s-ci-robot
added
the
do-not-merge/hold
natasha41575
force-pushed
the
InternalAnno
branch
from
1ece990 to
db250ae
Compare
k8s-ci-robot
added
size/L
natasha41575
force-pushed
the
InternalAnno
branch
from
db250ae to
3d4e60f
Compare
|
Covered by #4061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of aligning with https://github.com/kubernetes-sigs/kustomize/pull/3995/files -
"For orchestration purposes, the orchestrator will use a set of annotations,
referred to as internal annotations." This PR updates the annotation prefixes of resource build annotations (which are used solely by the kustomize orchestrator) to have the internal prefix.
See discussion in #4061 (comment)