-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New kustomize.io website #4508
New kustomize.io website #4508
Conversation
|
Welcome @DavidJacob! |
Hi @DavidJacob. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
linkTitle: "Getting Started" | ||
weight: 2 | ||
description: > | ||
What does your user need to know to try your project? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some really minor comments from a brief pass over the contents. We don't have to get everything perfect from the beginning, so I'm thinking we can fix these few things, get this PR in, and then iterate on the exact layout/content we want after that.
Regarding the blueberry image, it looks like it's in site/content/fa/about/featured-background.jpg, have you done a grep of featured-background.jpg
to see where it's being used?
@DavidJacob: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
You found it! And now it is gone. We have a wonderful orange background colour for now which we can change in the future! Should we change anything more in this PR or start using separate PRs for adding content and modifying the site? |
The |
/lgtm
When the tests finish running, I'll merge this PR. We can start modifying the site and moving over content in separate PRs. Thank you so so much for working on this! Excited to see this progress forward in the next few weeks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidJacob, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm so happy to see this go in :) |
A start to #4338
Documentation
section to be more relevant for kustomizeThis is just to get us started, and hopefully we can start moving all the documentation into this hugo site going forward.
cc @KnVerey @natasha41575 @rob8714