-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring hugo settings to match cli-experimental settings #4606
Configuring hugo settings to match cli-experimental settings #4606
Conversation
|
Welcome @unrolled! |
Hi @unrolled. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@unrolled: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
HUGO_VERSION = "0.92.2" | ||
|
||
[context.deploy-preview.environment] | ||
HUGO_VERSION = "0.92.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we could use [build.environment]
to set this for all envs? https://docs.netlify.com/integrations/frameworks/hugo/#hugo-version
Since this is what the old site is using, let's keep it for now. But I'll drop a question with SIG Docs, since it's not what kubernetes.io uses. Slack thread
When we are preparing to launch, we'll need to actually request the Netlify site using this process: Subproject Site Requests. There are a few more Netlify settings in the example that we likely want, notably the different commands for the non-production environments. |
/lgtm Since the site isn't live yet, let's get these improvements in. Additional tweaks can be made in a follow-up, notably once we hear back from SIG Docs. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, unrolled The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is part of the larger docs clean up issue: #4338
I went through the cli-experimental/site/config.toml file and brought over any necessary changes to match the styling and functionality of the SIG-CLI docs site. I also copied the cli-experimental/netlify.toml as it will be needed in the near future.
Couple of questions for the reviewers:
I left a question about locales on slack that may apply to this config cleanup