Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring hugo settings to match cli-experimental settings #4606

Merged
merged 1 commit into from
May 6, 2022
Merged

Configuring hugo settings to match cli-experimental settings #4606

merged 1 commit into from
May 6, 2022

Conversation

unrolled
Copy link
Contributor

@unrolled unrolled commented Apr 23, 2022

This PR is part of the larger docs clean up issue: #4338

I went through the cli-experimental/site/config.toml file and brought over any necessary changes to match the styling and functionality of the SIG-CLI docs site. I also copied the cli-experimental/netlify.toml as it will be needed in the near future.

Couple of questions for the reviewers:

  1. Is the copyright text correct for the site?
  2. I left a question about locales on slack that may apply to this config cleanup
  3. Any additional setup for netlify needed?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 23, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: unrolled / name: Cory Jacobsen (3bc5ca4)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 23, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @unrolled!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @unrolled. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 23, 2022
@k8s-ci-robot
Copy link
Contributor

@unrolled: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2022
@KnVerey
Copy link
Contributor

KnVerey commented May 6, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2022
HUGO_VERSION = "0.92.2"

[context.deploy-preview.environment]
HUGO_VERSION = "0.92.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we could use [build.environment] to set this for all envs? https://docs.netlify.com/integrations/frameworks/hugo/#hugo-version

@KnVerey
Copy link
Contributor

KnVerey commented May 6, 2022

Is the copyright text correct for the site?

Since this is what the old site is using, let's keep it for now. But I'll drop a question with SIG Docs, since it's not what kubernetes.io uses. Slack thread

Any additional setup for netlify needed?

When we are preparing to launch, we'll need to actually request the Netlify site using this process: Subproject Site Requests. There are a few more Netlify settings in the example that we likely want, notably the different commands for the non-production environments.

@KnVerey
Copy link
Contributor

KnVerey commented May 6, 2022

/lgtm
/approve

Since the site isn't live yet, let's get these improvements in. Additional tweaks can be made in a follow-up, notably once we hear back from SIG Docs.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, unrolled

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 46d4934 into kubernetes-sigs:master May 6, 2022
@unrolled unrolled deleted the unrolled-4338-config-site-setup branch May 11, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants