Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow resources to be configured in Helm chart #802

Merged
merged 1 commit into from
Nov 2, 2024
Merged

allow resources to be configured in Helm chart #802

merged 1 commit into from
Nov 2, 2024

Conversation

EladDolev
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

adds the ability for defining resources

Special notes for your reviewer:

not sure whether I need to bump the chart version and/or add release notes :-)

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @EladDolev!

It looks like this is your first PR to kubernetes-sigs/scheduler-plugins 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/scheduler-plugins has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @EladDolev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit e9b0097
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66f167b0701eb70008473ef0

@ffromani
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2024
Huang-Wei
Huang-Wei reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EladDolev, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1cda746 into kubernetes-sigs:master Nov 2, 2024
10 checks passed
fali007 added a commit to fali007/scheduler-plugins that referenced this pull request Nov 6, 2024
@fali007
Squashed commit of the following:
7c8d9c3 
commit 3d63730
Merge: dc97958 56323b7
Author: Kubernetes Prow Robot <[email protected]>
Date:   Tue Nov 5 06:35:28 2024 +0000

    Merge pull request kubernetes-sigs#822 from Huang-Wei/update-helm-index

    update helm chart index to include version 0.30.6

commit 56323b7
Author: Wei Huang <[email protected]>
Date:   Sun Nov 3 16:24:33 2024 -0800

    update helm chart index to include version 0.30.6

commit dc97958
Merge: aadfeeb b254cef
Author: Kubernetes Prow Robot <[email protected]>
Date:   Mon Nov 4 00:15:27 2024 +0000

    Merge pull request kubernetes-sigs#820 from Huang-Wei/0.30-doc-update

    doc update for v0.30.6

commit b254cef
Author: Wei Huang <[email protected]>
Date:   Sun Nov 3 15:55:38 2024 -0800

    doc update for v0.30.6

commit aadfeeb
Merge: 44370e5 59a8b1c
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sun Nov 3 18:43:27 2024 +0000

    Merge pull request kubernetes-sigs#813 from googs1025/feature/contextual_logging

    feature: use contextal logging

commit 59a8b1c
Author: googs1025 <[email protected]>
Date:   Tue Oct 29 13:28:33 2024 +0800

    feature: use contextal logging

commit 44370e5
Merge: ecc6093 da60eee
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sat Nov 2 19:11:32 2024 +0000

    Merge pull request kubernetes-sigs#817 from Huang-Wei/bump-k8s-v1.30.6

    bump k8s deps to v1.30.6

commit ecc6093
Merge: 1cda746 6ad9aab
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sat Nov 2 19:11:26 2024 +0000

    Merge pull request kubernetes-sigs#805 from odeinjul/patch-1

    fix: fix wrong PreemptionToleration policy example

commit 1cda746
Merge: fb31908 e9b0097
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sat Nov 2 18:45:26 2024 +0000

    Merge pull request kubernetes-sigs#802 from EladDolev/helm_resources

    allow resources to be configured in Helm chart

commit da60eee
Author: Wei Huang <[email protected]>
Date:   Sat Nov 2 11:28:05 2024 -0700

    vendor/

commit dd2d026
Author: Wei Huang <[email protected]>
Date:   Sat Nov 2 11:27:52 2024 -0700

    go module changes

commit fb31908
Merge: 9497a4e fd14d64
Author: Kubernetes Prow Robot <[email protected]>
Date:   Thu Oct 31 18:37:27 2024 +0000

    Merge pull request kubernetes-sigs#814 from blend/scheduler-command

    Allow specifying the scheduler container entrypoint in the helm chart

commit 9497a4e
Merge: bb56af1 57333b5
Author: Kubernetes Prow Robot <[email protected]>
Date:   Thu Oct 31 07:59:25 2024 +0000

    Merge pull request kubernetes-sigs#815 from blend/fix-leader-election

    Fix leader election config in the helm chart

commit 57333b5
Author: Chotiwat Chawannakul <[email protected]>
Date:   Wed Oct 30 18:02:27 2024 -0700

    fix rbac

commit 665f1ba
Author: Chotiwat Chawannakul <[email protected]>
Date:   Wed Oct 30 17:19:04 2024 -0700

    fix leader election config

commit fd14d64
Author: Chotiwat Chawannakul <[email protected]>
Date:   Mon Oct 28 18:42:10 2024 -0700

    allow specifying the scheduler container entrypoint in the helm chart

commit 6ad9aab
Author: Odeinjul <[email protected]>
Date:   Mon Sep 30 17:41:18 2024 -0500

    fix: fix wrong PreemptionToleration policy example

commit e9b0097
Author: Elad Dolev <[email protected]>
Date:   Mon Sep 23 15:52:42 2024 +0300

    allow resources to be configured in Helm chart

    Signed-off-by: Elad Dolev <[email protected]>
fali007 added a commit to fali007/scheduler-plugins that referenced this pull request Nov 6, 2024
@fali007
Squashed commit of the following:
2e18f02 
commit e29810d
Author: Felix George <[email protected]>
Date:   Tue Nov 5 15:56:06 2024 +0530

    Added changes to fix code review comments

    Signed-off-by: Felix George <[email protected]>

commit 243d9bb
Merge: 7f8f12d 3d63730
Author: Felix <[email protected]>
Date:   Tue Nov 5 15:07:52 2024 +0530

    Merge branch 'kubernetes-sigs:master' into master

commit 3d63730
Merge: dc97958 56323b7
Author: Kubernetes Prow Robot <[email protected]>
Date:   Tue Nov 5 06:35:28 2024 +0000

    Merge pull request kubernetes-sigs#822 from Huang-Wei/update-helm-index

    update helm chart index to include version 0.30.6

commit 7f8f12d
Author: Felix George <[email protected]>
Date:   Tue Nov 5 09:02:22 2024 +0530

    Formatting changes

    Signed-off-by: Felix George <[email protected]>

commit 287f005
Author: Krishnasuri Narayanam <[email protected]>
Date:   Mon Nov 4 16:20:17 2024 +0530

    integration test case for PEAKS plugin

    Signed-off-by: Krishnasuri Narayanam <[email protected]>

commit 3924f0a
Author: Krishnasuri Narayanam <[email protected]>
Date:   Mon Nov 4 16:02:14 2024 +0530

    unit and integration test cases for PEAKS plugin

    Signed-off-by: Krishnasuri Narayanam <[email protected]>

commit 56323b7
Author: Wei Huang <[email protected]>
Date:   Sun Nov 3 16:24:33 2024 -0800

    update helm chart index to include version 0.30.6

commit dc97958
Merge: aadfeeb b254cef
Author: Kubernetes Prow Robot <[email protected]>
Date:   Mon Nov 4 00:15:27 2024 +0000

    Merge pull request kubernetes-sigs#820 from Huang-Wei/0.30-doc-update

    doc update for v0.30.6

commit b254cef
Author: Wei Huang <[email protected]>
Date:   Sun Nov 3 15:55:38 2024 -0800

    doc update for v0.30.6

commit aadfeeb
Merge: 44370e5 59a8b1c
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sun Nov 3 18:43:27 2024 +0000

    Merge pull request kubernetes-sigs#813 from googs1025/feature/contextual_logging

    feature: use contextal logging

commit 59a8b1c
Author: googs1025 <[email protected]>
Date:   Tue Oct 29 13:28:33 2024 +0800

    feature: use contextal logging

commit 44370e5
Merge: ecc6093 da60eee
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sat Nov 2 19:11:32 2024 +0000

    Merge pull request kubernetes-sigs#817 from Huang-Wei/bump-k8s-v1.30.6

    bump k8s deps to v1.30.6

commit ecc6093
Merge: 1cda746 6ad9aab
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sat Nov 2 19:11:26 2024 +0000

    Merge pull request kubernetes-sigs#805 from odeinjul/patch-1

    fix: fix wrong PreemptionToleration policy example

commit 1cda746
Merge: fb31908 e9b0097
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sat Nov 2 18:45:26 2024 +0000

    Merge pull request kubernetes-sigs#802 from EladDolev/helm_resources

    allow resources to be configured in Helm chart

commit da60eee
Author: Wei Huang <[email protected]>
Date:   Sat Nov 2 11:28:05 2024 -0700

    vendor/

commit dd2d026
Author: Wei Huang <[email protected]>
Date:   Sat Nov 2 11:27:52 2024 -0700

    go module changes

commit fb31908
Merge: 9497a4e fd14d64
Author: Kubernetes Prow Robot <[email protected]>
Date:   Thu Oct 31 18:37:27 2024 +0000

    Merge pull request kubernetes-sigs#814 from blend/scheduler-command

    Allow specifying the scheduler container entrypoint in the helm chart

commit 9497a4e
Merge: bb56af1 57333b5
Author: Kubernetes Prow Robot <[email protected]>
Date:   Thu Oct 31 07:59:25 2024 +0000

    Merge pull request kubernetes-sigs#815 from blend/fix-leader-election

    Fix leader election config in the helm chart

commit 57333b5
Author: Chotiwat Chawannakul <[email protected]>
Date:   Wed Oct 30 18:02:27 2024 -0700

    fix rbac

commit 665f1ba
Author: Chotiwat Chawannakul <[email protected]>
Date:   Wed Oct 30 17:19:04 2024 -0700

    fix leader election config

commit fd14d64
Author: Chotiwat Chawannakul <[email protected]>
Date:   Mon Oct 28 18:42:10 2024 -0700

    allow specifying the scheduler container entrypoint in the helm chart

commit 6ad9aab
Author: Odeinjul <[email protected]>
Date:   Mon Sep 30 17:41:18 2024 -0500

    fix: fix wrong PreemptionToleration policy example

commit e9b0097
Author: Elad Dolev <[email protected]>
Date:   Mon Sep 23 15:52:42 2024 +0300

    allow resources to be configured in Helm chart

    Signed-off-by: Elad Dolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@zwpaper zwpaper Awaiting requested review from zwpaper

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EladDolev @k8s-ci-robot @ffromani @Huang-Wei