-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang sdk in 1.13 branch to use iam service account #2356
Update golang sdk in 1.13 branch to use iam service account #2356
Conversation
Welcome @rchernobelskiy! |
/assign @losipiuk |
@rchernobelskiy I have mixed feelings about that. It is very massive change for a bugfix. Also if we now followed to standard process of updating vendor as described in FAQ (which we probably will not do on 1.13 branch) we would overwrite your changes. Another thing is why the delta is that huge? Do we need all the SDK? @MaciekPytel PTAL - I would appreciate second opinion here. |
@losipiuk Thanks for looking into it. I figured you'd want the whole repo for the checksum to match. I can remove all the |
Fwiw, I'm building and running this locally for now and it works well. |
Friendly reminder for people using this: |
AWS_SDK_LOAD_CONFIG has been supported by using latest Session api. #2428 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: losipiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
More info: #2323
Thanks for looking into it, really appreciate the great work you guys do.