Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for different plural forms (feature request) #53

Closed
rbtcollins opened this issue Aug 13, 2018 · 11 comments
Closed

Support for different plural forms (feature request) #53

rbtcollins opened this issue Aug 13, 2018 · 11 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@rbtcollins
Copy link

We have a custom resource with a non-s plural form (Lets say a Bison CRD) - the plural of Bison is Bison.

The API server etc all seem to handle this fine, but I can't see a tag to control this in code-gen at the moment. Right now I'm handling that by post-processing the generated code (sed -e /bisons/bison/) but this is suboptimal.
This was referenced Oct 9, 2018
Merged
Closed
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Oct 9, 2018
@bobcatfish
Add PipelineRun integration test and refactor unit tests
edd0bef 
Added the beginnings of a skeleton of an integration test for
PipelineRun for #61. In doing this I realized that I couldn't create
PipelineParam objects with the clients b/c the plural name was wrong -
it needs to be `pipelineparamses` like I'm Smeagol. I tried to work
around this and stumbled on
kubernetes/code-generator#53 so it doesn't
seem to be possible without changing the code-generator code :(

Meanwhile refactored the existing controller code to break some code out
of the Reconciler, so it can be instantiated without an entire
controller (instead depends only on the objects it needs). The decision about
what TaskRuns to create has been separated from the logic to retrieve
existing ones, and the logic to create them. (`GetTasks`,
`getNextPipelineRunTaskRun`)

The tests were refactored such that the success cases are in separate
tests from the failure cases, so the table driven tests dont have to
handle both and it's more clear what the tests are doing.
knative-prow-robot pushed a commit to tektoncd/pipeline that referenced this issue Oct 10, 2018
@bobcatfish @knative-prow-robot
Add PipelineRun integration test and refactor unit tests
ecf71f6 
Added the beginnings of a skeleton of an integration test for
PipelineRun for #61. In doing this I realized that I couldn't create
PipelineParam objects with the clients b/c the plural name was wrong -
it needs to be `pipelineparamses` like I'm Smeagol. I tried to work
around this and stumbled on
kubernetes/code-generator#53 so it doesn't
seem to be possible without changing the code-generator code :(

Meanwhile refactored the existing controller code to break some code out
of the Reconciler, so it can be instantiated without an entire
controller (instead depends only on the objects it needs). The decision about
what TaskRuns to create has been separated from the logic to retrieve
existing ones, and the logic to create them. (`GetTasks`,
`getNextPipelineRunTaskRun`)

The tests were refactored such that the success cases are in separate
tests from the failure cases, so the table driven tests dont have to
handle both and it's more clear what the tests are doing.
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2018
@rbtcollins
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2018
@nikhita
Copy link
Member

nikhita commented Dec 12, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2019
@rbtcollins
Copy link
Author

rbtcollins commented Mar 12, 2019 via email

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 10, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alewitt2
Copy link

/reopen

@k8s-ci-robot
Copy link

@alewitt2: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alewitt2 alewitt2 mentioned this issue Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rbtcollins @nikhita @k8s-ci-robot @fejta-bot @alewitt2