Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for volume provisioning #2495

Merged
merged 12 commits into from
Aug 25, 2018
Merged

Add data source for volume provisioning #2495

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
216e4d4
Add data source for volume operations
jingxu97 Aug 7, 2018
0bdaa17
Update data-source.md
jingxu97 Aug 7, 2018
4c89dc5
Update data-source.md
jingxu97 Aug 9, 2018
29c02bc
Update data-source.md
jingxu97 Aug 10, 2018
bac19f0
Update data-source.md
jingxu97 Aug 20, 2018
22021f2
Update data-source.md
jingxu97 Aug 20, 2018
095154f
Update data-source.md
jingxu97 Aug 20, 2018
c900a72
Update data-source.md
jingxu97 Aug 20, 2018
12fc30d
Update data-source.md
jingxu97 Aug 21, 2018
7e30335
Update data-source.md
jingxu97 Aug 23, 2018
4effd1a
Update data-source.md
jingxu97 Aug 24, 2018
8c6cea4
Update data-source.md
jingxu97 Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contributors/design-proposals/storage/data-source.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ type TypedLocalObjectReference struct {
Name string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which line?

// Kind indicates the type of the object reference.
Kind string
// APIGroup is the group for the resource being referenced
APIGroup string
}

```
Expand All @@ -46,18 +48,16 @@ type PersistentVolumeStatus struct {

type PersistentVolumeConditionType string

// These are valid conditions of Pvc
// These are valid conditions of PersistentVolume
const (
// An user trigger resize of pvc has been started
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PersistentVolume rather than pvc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this condition describes whether data is populated to a PersistentVolume.

The comments should be fixed though. This is not about "resize".

PersistentVolumeDataPopulated PersistentVolumeConditionType = "dataPopulated"
PersistentVolumeDataPopulated PersistentVolumeConditionType = "DataPopulated"
)

type PersistentVolumeCondition struct {
Type PersistentVolumeConditionType
Status ConditionStatus
// +optional
LastProbeTime metav1.Time
// +optional
LastTransitionTime metav1.Time
// +optional
Reason string
Expand Down