-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port serviceaccount token volume design proposal to KEP #1594
Conversation
Welcome @zshihang! |
Hi @zshihang. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc mikedanese |
This turns the proposal here: https://github.com/kubernetes/community/blob/e3a6b8172fec9506b15520549e52be683e30cbfb/contributors/design-proposals/storage/svcacct-token-volume-source.md into a KEP so we can prepare for GA. |
/lgtm |
lgtm as a port of the original design, would recommend adding the original reviewers/approvers to the doc would like to merge this as-is (since it's a move of a historical document), then iterate on the migration plan |
89bc2c9
to
85835c0
Compare
/ok-to-test |
@zshihang: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
on top of this, i'll add the proposal for file permission handling
Thanks for the clarification. No objections to porting design doc to KEP and iterating on it. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese, saad-ali, zshihang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this PR is a copy of the pre-existing design proposal kubernetes/community#1973 and we would like to convert the design proposal into this KEP and iterate on it. more changes can be expected in subsequent PRs to this KEP with the goal of GA this feature which provides nice security properties.