Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create empty release notes doc for commenting #203

Merged
merged 41 commits into from
Mar 24, 2017

Conversation

calebamiles
Copy link
Contributor

For the 1.5 release we created a draft here for manual curation. Anyone who has write access to the repo should be able to update the PR on the release-notes-draft-1.6 branch and we can merge the draft in a single PR. please do not edit this file on the master branch

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2017
adds sections for each SIG
no updates for 1.6 release
@calebamiles calebamiles added this to the v1.6 milestone Mar 15, 2017
@calebamiles
Copy link
Contributor Author

@shtatfeld could you please comment as to the format of release note you've heard users ask for. Thanks!

- Introduce apps/v1beta1.Deployments resource with modified defaults compared to extensions/v1beta1.Deployments. ([#39683](https://github.com/kubernetes/kubernetes/pull/39683), [@soltysh](https://github.com/soltysh))
- Introduce new generator for apps/v1beta1 deployments ([#42362](https://github.com/kubernetes/kubernetes/pull/42362), [@soltysh](https://github.com/soltysh))
### Notable Changes
- Implement the update feature for DaemonSet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as new feature

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the new commit

- ReplicaSet has onwer ref of the Deployment that created it ([#35676](https://github.com/kubernetes/kubernetes/pull/35676), [@krmayankk](https://github.com/krmayankk))
### Breaking Changes
- Remove extensions/v1beta1 Jobs resource, and job/v1beta1 generator. ([#38614](https://github.com/kubernetes/kubernetes/pull/38614), [@soltysh](https://github.com/soltysh))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old kubectl edit deployment is broken kubernetes/kubernetes#42392

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarify you can kubectl edit deployment.extensions ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in the new commit

Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lukemarsden and others added 5 commits March 20, 2017 15:50
github.com/kubernetes-incubator/external-storage
1. Move DaemonSet update from notable changes to new feature 
2. Add a known breaking issue for kubectl edit deployment
@idvoretskyi
Copy link
Member

The ready-to-review version is at #218

@@ -59,12 +59,63 @@

## Cluster Lifecycle
### New Features
- kubeadm is a simple tool for creating Kubernetes clusters on existing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add the new features only from the spreadsheet, that reflects the features repo.

Only the items from the "features" repo have to be present at the "New features" section; please, move other to the "notable changes" or "breaking changes".

Copy link
Member

@idvoretskyi idvoretskyi Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD. The features, landed under SIG-ClusterLifecycle (per spreadsheet and the features repo) are:

New Features

  • [alpha] New Bootstrap Token authentication and management method. Works well with kubeadm.
  • [alpha] Adds a new cloud-controller-manager binary that may be used for testing the new out-of-core cloudprovider flow.
  • [beta] Introduces an API for the Kubelet to request TLS certificates from the API server.
  • [beta] kubeadm is enhanced and improved with a baseline feature set and command line flags that are now marked as beta.

@calebamiles
Copy link
Contributor Author

@dchen1107, @yujuhong, @vishh, @derekwaynecarr please add any additional information to the release notes draft. Please also include the latest tested docker version. It would also be great if you could move the release notes scraped from PRs at the bottom of the draft to the SIG Node section

**cc: @ethernetdan, @idvoretskyi, @kubernetes/kubernetes-release-managers, @kubernetes/sig-node-feature-requests.

## Node
### New Features
### Notable Changes
- The Docker-CRI implementation is Beta and is enabled by default in kubelet. You can disable it by --enable-cri=false. See [notes on the new implementation]( https://github.com/kubernetes/community/blob/master/contributors/devel/container-runtime-interface.md#kubernetes-v16-release-docker-cri-integration-beta) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the seriousness of these changes, I'd recommend placing them at the top of the release notes to ensure all users will see it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the notable changes are grouped by sigs though, so I don't know why we could do that.

I've already added more instructions at the ACTION REQUIRED section at the bottom. Do you think that would be enough?

### New Features
### Notable Changes
- The Docker-CRI implementation is Beta and is enabled by default in kubelet. You can disable it by --enable-cri=false. See [notes on the new implementation]( https://github.com/kubernetes/community/blob/master/contributors/devel/container-runtime-interface.md#kubernetes-v16-release-docker-cri-integration-beta) for more details.
- kubelet launches pods in a new cgroup hierarchy to better enforce quality of service. Operators must drain all pods from their nodes prior to upgrade of the kubelet. They must ensure the configured cgroup driver matches their associated container runtime cgroup driver.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opt-out instructions are missing -

You can disable this feature by setting --cgroups-per-qos=false, --enforce-node-allocatable=""

- ReplicaSet has onwer ref of the Deployment that created it ([#35676](https://github.com/kubernetes/kubernetes/pull/35676), [@krmayankk](https://github.com/krmayankk))
### Breaking Changes
- Remove extensions/v1beta1 Jobs resource, and job/v1beta1 generator. ([#38614](https://github.com/kubernetes/kubernetes/pull/38614), [@soltysh](https://github.com/soltysh))
- 1.5 kubectl can't do `kubectl edit deployment` on 1.6 server ([#42392](https://github.com/kubernetes/kubernetes/issues/42392)). Current workaround is to either upgrade to 1.6 kubectl, or run `kubectl edit deployment.extensions` instead of `kubectl edit deployment`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided this is a release blocker and we're going to fix this with kubernetes/kubernetes#43543. We can remove this item from release note once the fix is merged

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now fixed by kubernetes/kubernetes#43553

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this item from release note

### New Features
### Notable Changes
- The Docker-CRI implementation is Beta and is enabled by default in kubelet. You can disable it by --enable-cri=false. See [notes on the new implementation]( https://github.com/kubernetes/community/blob/master/contributors/devel/container-runtime-interface.md#kubernetes-v16-release-docker-cri-integration-beta) for more details.
- kubelet launches pods in a new cgroup hierarchy to better enforce quality of service. Operators must drain all pods from their nodes prior to upgrade of the kubelet. They must ensure the configured cgroup driver matches their associated container runtime cgroup driver.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more item to add -

Hard eviction thresholds will be subtracted from the Allocatable capacity on nodes to improve node reliability. This can break existing clusters since the overall schedulable capacity would reduce after upgrading to v1.6. 
You can opt-out of this feature by specifying --experimental-allocatable-ignore-eviction=true. 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishh you can just edit the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@idvoretskyi
Copy link
Member

Merging this draft in the current state. For further changes, please, send a separate PR.

@idvoretskyi idvoretskyi merged commit e6a5e11 into master Mar 24, 2017
@calebamiles calebamiles deleted the release-notes-draft-1.6 branch March 24, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.