Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glossary doc #2762

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Add glossary doc #2762

merged 1 commit into from
Jun 23, 2021

Conversation

annajung
Copy link
Contributor

Signed-off-by: Anna Jung (VMware) [email protected]

  • Add a glossary of frequently used enhancement related terms and link to relevant pages

fixes #2517

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2021
@annajung
Copy link
Contributor Author

cc @kikisdeliveryservice

palnabarun
palnabarun reviewed May 21, 2021
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thanks, @annajung for spinning up this glossary! 🎉

docs/glossary.md Outdated Show resolved Hide resolved
@annajung annajung requested a review from palnabarun May 21, 2021 01:13
@palnabarun
Copy link
Member

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 21, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@annajung annajung mentioned this pull request May 21, 2021
Closed
3 tasks
kikisdeliveryservice
kikisdeliveryservice requested changes May 24, 2021
View reviewed changes
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@palnabarun
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2021
kikisdeliveryservice
kikisdeliveryservice reviewed May 27, 2021
View reviewed changes
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few final comments 😄

docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
Add glossary doc
65a3dd1 
Signed-off-by: Anna Jung (VMware) <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 23, 2021 •
edited
Loading

readding nabarun's lgtm so this can merge
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 34d64cf into kubernetes:master Jun 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 23, 2021
@palnabarun palnabarun mentioned this pull request Jun 12, 2022
Closed
@palnabarun palnabarun mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@kikisdeliveryservice kikisdeliveryservice

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

[Enhancements Repo Documentation] Create Glossary
4 participants
@annajung @palnabarun @k8s-ci-robot @kikisdeliveryservice