-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2371: update criteria for alpha #3353
Conversation
and move the KEP stage to alpha, as more work is needed before the KEP can be considered alpha Signed-off-by: Peter Hunt <[email protected]>
I have pivoted. I don't think this KEP will be ready for beta. I think we should retarget at alpha, and update the alpha criteria to include broadcasting cAdvisor metrics from the CRI. That way, we can properly evaluate performance and stability in beta (once we have actual feedback on them). I would not consider this KEP at MVP stage without the cAdvisor metrics coming from somewhere, so I think it's better in alpha. @bobbypage @mrunalp PTAL |
/lgtm |
status: implementable | ||
stage: beta | ||
latest-milestone: "v1.24" | ||
stage: alpha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is targeting beta
in v1.25, right? If so, stage
, latest-milestone
and milestone.beta
needs to reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually no, this is an update to the alpha stage. It was originally targeting beta but I reconsidered
Signed-off-by: Peter Hunt <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Peter Hunt [email protected]