Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2254: Target sig-node cgroupv2 KEP to GA in 1.25 #3405

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Jun 16, 2022

Signed-off-by: David Porter [email protected]

  • One-line PR description: Target sig-node cgroupv2 KEP to GA in 1.25
  • Update the KEP.yaml
  • Update based on the new KEP template and added testing info
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2022
@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 June 16, 2022 21:35
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 16, 2022
@bobbypage
Copy link
Member Author

/assign @mrunalp

@bobbypage bobbypage changed the title Update cgroupv2 KEP to target GA in 1.25 KEP-2254 - Target cgroupv2 KEP to GA in 1.25 Jun 16, 2022
@bobbypage bobbypage changed the title KEP-2254 - Target cgroupv2 KEP to GA in 1.25 KEP-2254: Target sig-node cgroupv2 KEP to GA in 1.25 Jun 16, 2022
@bobbypage bobbypage force-pushed the cg2-kep-ga-updates branch 2 times, most recently from 806ff1c to 90af456 Compare June 16, 2022 21:42
* Update the KEP.yaml
* Update based on the new KEP template and added testing info

Signed-off-by: David Porter <[email protected]>
@bobbypage bobbypage force-pushed the cg2-kep-ga-updates branch from 90af456 to e9ffd1b Compare June 16, 2022 21:46
@mrunalp
Copy link
Contributor

mrunalp commented Jun 16, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@bobbypage
Copy link
Member Author

/assign @derekwaynecarr

@mrunalp
Copy link
Contributor

mrunalp commented Jun 16, 2022

@derekwaynecarr for approval

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@bobbypage
Copy link
Member Author

/assign @johnbelamaric

for PRR

@johnbelamaric
Copy link
Member

/approve

Would there be value in making it visible in the Node status that the node is using cgroup v2?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, derekwaynecarr, johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 949bd7d into kubernetes:master Jun 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 20, 2022
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jun 21, 2022
4 tasks
@ReillyBrogan
Copy link

Would there be value in making it visible in the Node status that the node is using cgroup v2?

Yes, I think so. It might be a good candidate for a node label so that pods can target pure v1, pure v2, or hybrid mode v1/v2. Some applications that expect an older setup could experience issues if a node is pure v2. Applications using Java 8 or Java 11 <= 11.0.16 for example don't accurately detect CPU/memory limits when ran on v2-only systems.

@bobbypage
Copy link
Member Author

Thanks @johnbelamaric for reviewing.

@ReillyBrogan Regarding exposing cgroup version in node status, that's a good idea and we should discuss it further. Let's move discussion to the parent issue so it does not get lost in this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants