-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2254: Target sig-node cgroupv2 KEP to GA in 1.25 #3405
Conversation
/assign @mrunalp |
806ff1c
to
90af456
Compare
* Update the KEP.yaml * Update based on the new KEP template and added testing info Signed-off-by: David Porter <[email protected]>
90af456
to
e9ffd1b
Compare
/lgtm |
/assign @derekwaynecarr |
@derekwaynecarr for approval |
/approve |
/assign @johnbelamaric for PRR |
/approve Would there be value in making it visible in the Node status that the node is using cgroup v2? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobbypage, derekwaynecarr, johnbelamaric The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, I think so. It might be a good candidate for a node label so that pods can target pure v1, pure v2, or hybrid mode v1/v2. Some applications that expect an older setup could experience issues if a node is pure v2. Applications using Java 8 or Java 11 <= 11.0.16 for example don't accurately detect CPU/memory limits when ran on v2-only systems. |
Thanks @johnbelamaric for reviewing. @ReillyBrogan Regarding exposing cgroup version in node status, that's a good idea and we should discuss it further. Let's move discussion to the parent issue so it does not get lost in this PR :) |
Signed-off-by: David Porter [email protected]