Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update kep 3288 #4879

Merged
merged 2 commits into from
Sep 30, 2024
Merged

feat: update kep 3288 #4879

merged 2 commits into from
Sep 30, 2024

Conversation

knight42
Copy link
Member

Note down why we decide not to support the combination of Stream and TailLines.

Per kubernetes/kubernetes#127360 (comment)

@knight42
feat: update kep 3288
cda758d 
Note down why we decide not to support the combination of `Stream` and
`TailLines`.

Signed-off-by: Jian Zeng <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2024
@knight42
Copy link
Member Author

/cc @SergeyKanzhelev @kannon92

@knight42 knight42 mentioned this pull request Sep 28, 2024
Merged
SergeyKanzhelev
SergeyKanzhelev reviewed Sep 28, 2024
View reviewed changes
keps/sig-node/3288-separate-stdout-from-stderr/README.md Outdated
rather than potentially all of them. However, this may go against users' expectations and could lead to confusion.

Taking all these considerations into account, I propose that we do not support the combination of `Stream` and `TailLines`
in the first iteration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a note that the validation will be performed when this is requested and error will be returned.

SergeyKanzhelev
SergeyKanzhelev reviewed Sep 28, 2024
View reviewed changes
keps/sig-node/3288-separate-stdout-from-stderr/README.md Outdated
rather than potentially all of them. However, this may go against users' expectations and could lead to confusion.

Taking all these considerations into account, I propose that we do not support the combination of `Stream` and `TailLines`
in the first iteration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add this to the non-goals on line 179

@SergeyKanzhelev
Copy link
Member

lgtm. I think KEP brings a lot of value even with this limitation. Implementation-wise for the long term if we decide to support this, we will need to think whether we can split files when they are written.

@knight42
Copy link
Member Author

@SergeyKanzhelev I have updated the kep as you suggested, PTAL.

@knight42
address comments
e9bec8c 
Signed-off-by: Jian Zeng <[email protected]>
@knight42 knight42 mentioned this pull request Sep 29, 2024
Open
10 tasks
@pacoxu
Copy link
Member

pacoxu commented Sep 30, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knight42, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 717e0a6 into kubernetes:master Sep 30, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@kannon92 kannon92 Awaiting requested review from kannon92

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@knight42 @SergeyKanzhelev @pacoxu @k8s-ci-robot @mrunalp