Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update k8s api to 0.22.2 #1652

Closed
wants to merge 1 commit into from
Closed

Conversation

anthonyho007
Copy link

@anthonyho007 anthonyho007 commented Jan 11, 2022

to fix ingress-gce apis import error due to kubernetes/kube-openapi#234

../../../../pkg/mod/k8s.io/[email protected]/pkg/apis/backendconfig/v1/zz_generated.openapi.go:49:3: cannot use "github.com/go-openapi/spec".Schema{...} (type "github.com/go-openapi/spec".Schema) as type "k8s.io/kube-openapi/pkg/validation/spec".Schema in field value

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @anthonyho007!

It looks like this is your first PR to kubernetes/ingress-gce 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-gce has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @anthonyho007. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anthonyho007
To complete the pull request process, please assign bowei after the PR has been reviewed.
You can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gillesdouaire
Copy link

Running into this issue when working on Kubernetes 1.22 compatibility, we have a strong dependency on this. This PR is much needed and appreciated 👍

@gillesdouaire
Copy link

gillesdouaire commented Feb 3, 2022

@bowei @swetharepakula this is getting pretty critical.

@swetharepakula
Copy link
Member

Thanks for the PR! We have been holding back on this because we have needed elements from older K8s releases for the e2e tests. Our e2e tests need to be able to run against K8s versions earlier than 1.22 which has been our biggest blocker. We will reevaluate our decision and see if we are in a position to update now.

However before this change can be made, the dependency changes require ingress-gce to be updated to use Go 1.16 or higher.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2022
@bharathguvvala
Copy link

/retest

1 similar comment
@shield-9
Copy link

shield-9 commented Apr 2, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

@anthonyho007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress-gce-test f368570 link true /test pull-ingress-gce-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@swetharepakula
Copy link
Member

The repo has been updated to use Golang 1.16, which unblocks the upgrade to k8s api 0.22.2. Please try rebasing. The test failures are not flakes but due to the golang versions

@sugangli
Copy link
Contributor

/assign @bowei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants