Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild echo server #9754

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Mar 18, 2023

What this PR does / why we need it:

  • Alpine and golang needed to be bumped for CVE and performance to go-1.20 and alpine-3.17.2
  • images of the project were rebuilt and promoted from staging to prod in https://github.com/kubernetes/k8s.io/pull/4929/files
  • echo server image was not rebuilt because rebuilt was not triggered because no file was edited under /images/echo
  • So this PR makes a dummy cosmetic edit (adding a space) to makefile of the echo server.
  • This is expected to fire a build for echo server with new go-1.20 and alpine-3.17.2 .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

Build echo server with go1.20 and alpine 3.17.2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/helm Issues or PRs related to helm charts needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @SaumyaBhushan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2023
@SaumyaBhushan SaumyaBhushan changed the title updated digest and tags of images Rebuild echo server Mar 18, 2023
@longwuyuan
Copy link
Contributor

Thanks.
/ok-to-test
/triage accepted
/area stabilization
/remove-area helm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. area/stabilization Work for increasing stabilization of the ingress-nginx codebase and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/helm Issues or PRs related to helm charts needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 18, 2023
@longwuyuan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2023
@strongjz
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, SaumyaBhushan, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit fec1dbe into kubernetes:main Mar 18, 2023
@longwuyuan
Copy link
Contributor

@SaumyaBhushan echo-server new build details below. Follow up PRs needed to promote this image from staging to prod and then to change project code to use this new tag+sha
Image type
Docker Manifest, Schema 2
Media type
application/vnd.docker.distribution.manifest.v2+json
Project
k8s-staging-ingress-nginx
Repository
e2e-test-echo
Digest
sha256:4938d1d91a2b7d19454460a8c1b010b89f6ff92d2987fd889ac3e8fc3b70d91a
Virtual size
93.9 MB
Created
Mar 19, 2023, 3:45:11 AM
Uploaded
Mar 19, 2023, 3:45:17 AM
Tags
v20230318-helm-chart-4.5.2-44-gfec1dbe3a

image

@SaumyaBhushan
Copy link
Contributor Author

SaumyaBhushan commented Mar 19, 2023

@SaumyaBhushan echo-server new build details below. Follow up PRs needed to promote this image from staging to prod and then to change project code to use this new tag+sha Image type Docker Manifest, Schema 2 Media type application/vnd.docker.distribution.manifest.v2+json Project k8s-staging-ingress-nginx Repository e2e-test-echo Digest sha256:4938d1d91a2b7d19454460a8c1b010b89f6ff92d2987fd889ac3e8fc3b70d91a Virtual size 93.9 MB Created Mar 19, 2023, 3:45:11 AM Uploaded Mar 19, 2023, 3:45:17 AM Tags v20230318-helm-chart-4.5.2-44-gfec1dbe3a

image

Sure @longwuyuan .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/stabilization Work for increasing stabilization of the ingress-nginx codebase cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants