Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename the kube-dns property in kubeadm alpha phase addon #856

Closed
neolit123 opened this issue May 24, 2018 · 0 comments · Fixed by kubernetes/kubernetes#64274
Closed

rename the kube-dns property in kubeadm alpha phase addon #856

neolit123 opened this issue May 24, 2018 · 0 comments · Fixed by kubernetes/kubernetes#64274
Assignees
@neolit123
Labels
area/UX priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.11

Comments

@neolit123
Copy link
Member

the kube-dns addon property is being present in kubeadm alpha phase addon.

the docs also mention the following:

**Please note that if kubeadm is invoked with --feature-gates=CoreDNS=true, CoreDNS is installed instead of kube-dns.**

https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-alpha/#cmd-phase-addon

CoreDNS is on by default in 1.11 which suggests that both the docs and the addon sub command need to change for that.

TODO:
@neolit123 neolit123 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/UX labels May 24, 2018
@neolit123 neolit123 added this to the v1.11 milestone May 24, 2018
@neolit123 neolit123 self-assigned this May 24, 2018
This was referenced May 24, 2018
Closed
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 29, 2018
Merge pull request #64274 from neolit123/kubeadm-alpha-phase-addon
046619f 
Automatic merge from submit-queue (batch tested with PRs 64308, 64367, 64165, 64274). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubeadm: rename the `kube-dns` phases addon

**What this PR does / why we need it**:
The command `kubeadm alpha phases addon` has a property
called `kube-dns` which would install kube-dns, pre 1.11.

In the case of 1.11 this property will install CoreDNS,
because the property is also bound to the `CoreDNS` feature gate,
which is now `true` by default.

Fix that by renaming the property to `coredns`, updating the Cobra
info and also updating the unit tests.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes/kubeadm#856

**Special notes for your reviewer**:
Please verify if we are OK with the "hard rename".

**Release note**:

```release-note
kubeadm: rename the addon parameter `kube-dns` to `coredns` for `kubeadm alpha phases addons` as CoreDNS is now the default DNS server in 1.11.
```

@kubernetes/sig-cluster-lifecycle-pr-reviews 
/area kubeadm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

Labels
area/UX priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.11
Development

Successfully merging a pull request may close this issue.

kubeadm: rename the kube-dns phases addon neolit123/kubernetes
1 participant
@neolit123