Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump cAdvisor to v0.47.1 #114883

Merged
merged 3 commits into from
Jan 12, 2023
Merged

deps: Bump cAdvisor to v0.47.1 #114883

merged 3 commits into from
Jan 12, 2023

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Jan 6, 2023 •
edited
Loading

Signed-off-by: David Porter [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bump cAdvisor to latest version. See google/cadvisor@v0.46.0...v0.47.1 for diff.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updated cAdvisor to v0.47.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/cloudprovider do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

@bobbypage: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/code-generation needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/dependency Issues or PRs related to dependency changes area/kubectl needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 6, 2023
@bobbypage
Copy link
Member Author

/assign @liggitt

@bobbypage
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims January 6, 2023 21:22
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@cici37
Copy link
Contributor

cici37 commented Jan 10, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 10, 2023
bobbypage added a commit to bobbypage/cadvisor that referenced this pull request Jan 10, 2023
@bobbypage
deps: Move from cloud.google.com/go/compute -> cloud.google.com/go
29ef691 
Moving to cloud.google.com/go/compute results in issue with k8s
publishing bot (see kubernetes/kubernetes#114883 (comment)).

This reverts to using cloud.google.com/go v0.97.0 which is currently
vendored into k8s.

Signed-off-by: David Porter <[email protected]>
@bobbypage bobbypage mentioned this pull request Jan 10, 2023
Merged
@liggitt liggitt mentioned this pull request Jan 11, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2023
bobbypage added a commit to bobbypage/cadvisor that referenced this pull request Jan 11, 2023
@bobbypage
deps: Move from cloud.google.com/go/compute -> cloud.google.com/go
95a07f7 
Moving to cloud.google.com/go/compute results in issue with k8s
publishing bot (see kubernetes/kubernetes#114883 (comment)).

This reverts to using cloud.google.com/go v0.97.0 which is currently
vendored into k8s.

Signed-off-by: David Porter <[email protected]>
@bobbypage bobbypage mentioned this pull request Jan 11, 2023
Merged
@bobbypage
deps: Bump to cAdvisor v0.47.1
761dd36 
Signed-off-by: David Porter <[email protected]>
@bobbypage
Update hack/unwanted-dependencies.json
a091699 
* Drop nvml since it is no longer used

Signed-off-by: David Porter <[email protected]>
@bobbypage
Remove AcceleratorUsageMetrics from kubelet
8e3a02e 
The feature gate is GA'd and enabled by default and the metrics have
been removed from cAdvisor.

Signed-off-by: David Porter <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023
@bobbypage bobbypage changed the title deps: Bump cAdvisor to v0.47.0 deps: Bump cAdvisor to v0.47.1 Jan 12, 2023
@bobbypage
Copy link
Member Author

bobbypage commented Jan 12, 2023 •
edited
Loading

Updated the PR to bump to cAdvisor v0.47.1 which includes google/cadvisor#3231. This points to cloud.google.com/go to address #114883 (comment)

@dims
Copy link
Member

dims commented Jan 12, 2023

thanks @bobbypage sorry about the 2-step-forward-1-step-back-tango :)

@pacoxu
Copy link
Member

pacoxu commented Jan 12, 2023 

-Direct Dependencies: 211 
-Transitive Dependencies: 234 
-Total Dependencies: 285 
+Direct Dependencies: 209 
+Transitive Dependencies: 233 
+Total Dependencies: 284 

-github.com/mindprince/gonvml

It looks good now.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd229e8b05b0a22ab6fec6d439f83097076a7af2

@xuzhenglun
Copy link
Contributor

xuzhenglun commented Jan 12, 2023 •
edited
Loading

After this pr is merged, are we able to disable cgo when building kubelet ? https://github.com/kubernetes/kubernetes/blob/master/hack/lib/golang.sh#L422

because in my understand the only cgo dependency is go-nvml lib. If this dependency is gone, It's seems like there is no reason to build kubelet with cgo (static binary is easier to build and distribute.

@liggitt
Copy link
Member

liggitt commented Jan 12, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@liggitt
Copy link
Member

liggitt commented Jan 12, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3e049c5 into kubernetes:master Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 12, 2023
@liggitt liggitt mentioned this pull request Jan 17, 2023
Merged
@pacoxu pacoxu mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@pacoxu pacoxu pacoxu left review comments

@liggitt liggitt liggitt left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@dims dims Awaiting requested review from dims

@aojea aojea Awaiting requested review from aojea

Assignees

@liggitt liggitt

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
[sig-architecture] Dependency management
Status: Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
8 participants
@bobbypage @k8s-ci-robot @dims @pacoxu @cici37 @xuzhenglun @liggitt @nikhita