Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fsGroup to vSphere #38655

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Fix fsGroup to vSphere #38655

merged 1 commit into from
Dec 23, 2016

Conversation

abrarshivani
Copy link
Contributor

What this PR does / why we need it:
Fixes #34039 by adding support for fsGroup to vSphere Volume.

Special notes for your reviewer:
Tested with example from http://stackoverflow.com/questions/35213589/docker-container-with-non-root-user-deployed-in-google-container-engine-can-not
Before this fix got error Permission Denied.

Release note:

NONE

cc @pdhamdhere @kerneltime @BaluDontu

@k8s-ci-robot
Copy link
Contributor

Hi @abrarshivani. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Dec 12, 2016
@abrarshivani abrarshivani mentioned this pull request Dec 12, 2016
Closed
@kerneltime
Copy link

@k8s-bot ok to test

@abrarshivani
Copy link
Contributor Author

@k8s-bot cvm gke e2e test this

@k8s-ci-robot
Copy link
Contributor

@abrarshivani: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot cvm gke e2e test this

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@BaluDontu
Copy link
Contributor

@k8s-bot cvm gke e2e test this

@k8s-ci-robot
Copy link
Contributor

@BaluDontu: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot cvm gke e2e test this

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@abrarshivani
Copy link
Contributor Author

@kerneltime Can you please run @k8s-bot cvm gke e2e test this?

@k8s-ci-robot
Copy link
Contributor

@abrarshivani: you can't request testing unless you are a kubernetes member.

In response to this comment:

@kerneltime Can you please run @k8s-bot cvm gke e2e test this?

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@kerneltime
Copy link

@k8s-bot ok to test

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 5cb7faa. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@kerneltime
Copy link

@k8s-bot cvm gke e2e test this

@abrarshivani
Copy link
Contributor Author

@thockin Can you please review this PR?

@thockin thockin added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Dec 23, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 39059, 39175, 35676, 38655)

@k8s-github-robot k8s-github-robot merged commit f1aa025 into kubernetes:master Dec 23, 2016
@kerneltime kerneltime mentioned this pull request Dec 24, 2016
Merged
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 4, 2017
jessfraz added a commit that referenced this pull request Jan 4, 2017
@jessfraz
Merge pull request #39210 from vmware/automated-cherry-pick-of-#38655…
4f75e33 
…-upstream-release-1.4

Automated cherry pick of #38655
@kerneltime kerneltime mentioned this pull request Jan 11, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 12, 2017
Merge pull request #39754 from vmware/automated-cherry-pick-of-#38655…
e21b2f3 
…-kubernetes-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #38655

Cherry pick of #38655 on release-1.5.

#38655: Fix fsGroup to vSphere
@kerneltime kerneltime mentioned this pull request Jan 13, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerneltime kerneltime kerneltime approved these changes

Assignees

@thockin thockin

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vsphere volume does not honor fsGroup
8 participants
@abrarshivani @k8s-ci-robot @k8s-reviewable @kerneltime @BaluDontu @k8s-github-robot @jessfraz @thockin