Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instance metadata service URL. #49081

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Fix instance metadata service URL. #49081

merged 1 commit into from
Jul 28, 2017

Conversation

brendandburns
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 18, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 18, 2017
colemickens
colemickens reviewed Jul 19, 2017
View reviewed changes
pkg/cloudprovider/providers/azure/azure_instance_metadata.go Outdated
var metadataURL = "http://169.254.169.254/metadata"
const metaURL = "http://169.254.169.254/metadata/"

var metadataURL = metaURL

// SetMetadataURLForTesting is used to modify the URL used for
// accessing the metadata server. Should only be used for testing!
func SetMetadataURLForTesting(url string) {
metadataURL = url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for package local testing? Does it need to be public?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

pkg/cloudprovider/providers/azure/azure_instance_metadata.go Outdated

// SetMetadataURLForTesting is used to modify the URL used for
// accessing the metadata server. Should only be used for testing!
func SetMetadataURLForTesting(url string) {
metadataURL = url
}

// ResetMetadataURLForTesting resets the metadata service URL to the default.
func ResetMetadataURLForTesting() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about unexporting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2017
@brendandburns
Copy link
Contributor Author

/test pull-kubernetes-verify
/test pull-kubernetes-federation-e2e-gce

@colemickens
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 20, 2017
jackfrancis
jackfrancis approved these changes Jul 25, 2017
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@brendandburns brendandburns added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Jul 26, 2017
@brendandburns
Copy link
Contributor Author

/approve no-issue

@brendandburns brendandburns added this to the v1.8 milestone Jul 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, colemickens, jackfrancis

Associated issue requirement bypassed by: brendandburns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2017
@jackfrancis jackfrancis mentioned this pull request Jul 26, 2017
Merged
@brendandburns
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-etcd3

2 similar comments
@brendandburns
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-etcd3

@brendandburns
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-etcd3

@fejta-bot
Copy link

/retest
Automated flake /retester experiment. Please send feedback to fejta

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49081, 49318, 49219, 48989, 48486)

@k8s-github-robot k8s-github-robot merged commit 9b8bc25 into kubernetes:master Jul 28, 2017
@jdumars
Copy link
Member

jdumars commented Aug 15, 2017

/sig azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemickens colemickens colemickens left review comments

@jackfrancis jackfrancis jackfrancis approved these changes

Assignees

@colemickens colemickens

@pmorie pmorie

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
9 participants
@brendandburns @colemickens @k8s-github-robot @fejta-bot @jdumars @jackfrancis @pmorie @smarterclayton @k8s-ci-robot