Scheduler - not able to read from config file if configmap is not found #59386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/sig scheduling |
k8s-ci-robot
added
the
sig/scheduling
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, ravisantoshgudimetla The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
bsalamat
reviewed
Feb 6, 2018
| @@ -214,7 +214,7 @@ func (o *Options) applyDeprecatedHealthzPortToConfig() { | |||
| // 3. --algorithm-provider to use a named algorithm provider. | |||
| func (o *Options) applyDeprecatedAlgorithmSourceOptionsToConfig() { | |||
| switch { | |||
| case o.useLegacyPolicyConfig: | |||
| case o.useLegacyPolicyConfig || (len(o.policyConfigFile) > 0 && o.policyConfigMapName == ""): | |||
There was a problem hiding this comment.
s/o.policyConfigMapName == ""/len(o.policyConfigMapName) == 0/
There was a problem hiding this comment.
@bsalamat - Shall I create another PR for this?
There was a problem hiding this comment.
@ravisantoshgudimetla No, thers is no need to send another PR.
Thanks for checking.
|
Automatic merge from submit-queue (batch tested with PRs 59165, 59386). If you want to cherry-pick this change to another branch, please follow the instructions here. |
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Feb 26, 2018
…fig-flag Automatic merge from submit-queue. UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found Scheduler is not able to read from config file if configmap is not found. Upstream PR: kubernetes/kubernetes#59386 xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785 /cc @aveshagarwal @sjenning
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Feb 27, 2018
…eduler-config-flag Automatic merge from submit-queue. UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found Scheduler is not able to read from config file if configmap is not found. Upstream PR: kubernetes#59386 xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785 /cc @aveshagarwal @sjenning Origin-commit: a1c2561ddfcb6c8d54c0188317dfabcbd25eca62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As of now, we are not able to read config file if configmap is not present. The only way to make it work is to enable legacy mode which should not be the case.
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785
Release note:
/cc @bsalamat @ironcladlou