-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable VolumeSnapshotDataSource Feature Gate #67625
Conversation
This PR adds TypedLocalObjectReference in the core API and adds DataSource in PersistentVolumeClaimSpec.
@xing-yang is there a tracking issue for this API change? |
@neolit123 Yes, it is here: kubernetes/enhancements#177 |
@xing-yang thanks! /kind feature |
/ok-to-test |
@neolit123 Added a release note. Thanks! |
/test pull-kubernetes-e2e-gce-100-performance |
Merge code to add DataPopulated condition to PV to featuregate branch
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xing-yang If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xing-yang: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I've included changes in this PR to #67087. So this can be closed now. |
What this PR does / why we need it:
This PR enables feature gate for VolumeSnapshotDataSource.
It also adds a condition called "DataPopulated" into PV. With the feature of snapshot and data source, volume might be created from snapshot source with data populated into the volume instead of an empty one. The external provisioner needs to understand the data source and also mark the condition "DataPopualted" to true. The PV controller will check this condition if the data source of PVC is specified. Only if the condition is true, the PVC can be marked as "Bound" phase.
Address design proposal: kubernetes/community#2495
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
kubernetes/enhancements#177
Special notes for your reviewer:
Release note: