Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubeconfig flag instead of kubeconfig-dir in kubeadm init phase bootstrap-token #71803

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Use kubeconfig flag instead of kubeconfig-dir in kubeadm init phase bootstrap-token #71803

merged 1 commit into from
Dec 6, 2018

Conversation

yagonobre
Copy link
Member

What type of PR is this?
/kind bug
What this PR does / why we need it:

Fixes kubernetes/kubeadm#1306

Special notes for your reviewer:
bootstrap-token is the unique phase that use data.Client() and kubeconfig-dir flag, that make sense only in the kubeconfig phase
Does this PR introduce a user-facing change?:
-->

kubeadm: use kubeconfig flag instead of kubeconfig-dir on init phase bootstrap-token

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2018
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 6, 2018
@yagonobre
Copy link
Member Author

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

neolit123
neolit123 approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix @yagonobre
/lgtm
/approve
/priority critical-urgent

/assign @fabriziopandini
should we cherry pick?

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 6, 2018
@yagonobre
Copy link
Member Author

+1 from me to cherry pick

@yagonobre
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@yagonobre
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2018
timothysc
timothysc approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/lgtm
/approve

Please cherry-pick and assign to me.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, timothysc, yagonobre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yagonobre yagonobre mentioned this pull request Dec 6, 2018
Merged
@yagonobre
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot merged commit fa0ef74 into kubernetes:master Dec 6, 2018
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
@k8s-ci-robot
Merge pull request #71817 from yagonobre/automated-cherry-pick-of-#71…
99078be 
…803-upstream-release-1.13

Automated cherry pick of #71803: Use kubeconfig flag instead of kubeconfig-dir in kubeadm init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 approved these changes

@timothysc timothysc timothysc approved these changes

@luxas luxas Awaiting requested review from luxas

Assignees

@timothysc timothysc

@neolit123 neolit123

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yagonobre @k8s-ci-robot @timothysc @neolit123 @fabriziopandini