Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet flag migration - Part 1 #88480

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Kubelet flag migration - Part 1 #88480

merged 1 commit into from
Apr 14, 2020

Conversation

savitharaghunathan
Copy link
Member

@savitharaghunathan savitharaghunathan commented Feb 24, 2020 •
edited by mtaufen
Loading

As a part of on-going Kubelet flags migration to config, this PR handles a part of the migration.

The flag that is addressed in this PR: volume-plugin-dir

Ref: #86843

/area kubelet
/area kubelet-api

The Kubelet's `--volume-plugin-dir` option is now available via the Kubelet config file field `VolumePluginDir`.

cc: @mtaufen @stealthybox

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Feb 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Feb 24, 2020
@savitharaghunathan
Copy link
Member Author

/retest

1 similar comment
@savitharaghunathan
Copy link
Member Author

/retest

@mtaufen mtaufen self-assigned this Feb 25, 2020
mtaufen
mtaufen reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@mtaufen mtaufen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good.

staging/src/k8s.io/kubelet/config/v1beta1/types.go Show resolved Hide resolved
pkg/kubelet/apis/config/v1beta1/defaults.go Show resolved Hide resolved
@savitharaghunathan savitharaghunathan force-pushed the kubelet_flag_migration_1 branch from b134fbb to 1ca3976 Compare March 7, 2020 16:36
@sjenning
Copy link
Contributor

sjenning commented Mar 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@savitharaghunathan savitharaghunathan changed the title WIP: Kubelet flag migration - Part 1 Kubelet flag migration - Part 1 Mar 9, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/kubelet-api and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

@savitharaghunathan: The label(s) area/ cannot be applied, because the repository doesn't have them

In response to this:

As a part of on-going Kubelet flags migration to config, this PR handles a part of the migration.

The flag that is addressed in this PR: volume-plugin-dir

Ref: #86843

/area kubelet
/area kubelet-api

The Kubelet's `--volume-plugin-dir` option is now available via the Kubelet config file field `VolumePluginDir`.

cc: @mtaufen @stealthybox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtaufen
Copy link
Contributor

mtaufen commented Mar 10, 2020

/lgtm
/approve

@mtaufen
Copy link
Contributor

mtaufen commented Mar 10, 2020

/hold
Please squash.
Feel free to cancel the hold after squash.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@savitharaghunathan savitharaghunathan force-pushed the kubelet_flag_migration_1 branch from 1ca3976 to 3234d34 Compare March 10, 2020 20:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@savitharaghunathan
Copy link
Member Author

I have squashed the commits. @mtaufen , @sjenning can you LGTM/approve again, please?

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@mtaufen
Copy link
Contributor

mtaufen commented Mar 10, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@savitharaghunathan
Copy link
Member Author

/assign @dchen1107 @smarterclayton

@dchen1107
Copy link
Member

/lgtm
/approve

@mtaufen
Copy link
Contributor

mtaufen commented Apr 14, 2020

/assign @liggitt
for final approval

@liggitt
Copy link
Member

liggitt commented Apr 14, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, liggitt, mtaufen, savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6c49931 into kubernetes:master Apr 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 14, 2020
@rfranzke rfranzke mentioned this pull request Aug 17, 2020
Closed
rfranzke added a commit to gardener/gardener that referenced this pull request Sep 1, 2020
@rfranzke
Use VolumePluginDir field in kubelet config for 1.19
6d34b65 
kubernetes/kubernetes#88480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@sjenning sjenning Awaiting requested review from sjenning

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@sjenning sjenning

@mtaufen mtaufen

@liggitt liggitt

@smarterclayton smarterclayton

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/kubelet-api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
8 participants
@savitharaghunathan @sjenning @fejta-bot @k8s-ci-robot @mtaufen @dchen1107 @liggitt @smarterclayton