Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable weight on the CPU and memory #90544

Merged
merged 1 commit into from
May 16, 2020
Merged

configurable weight on the CPU and memory #90544

merged 1 commit into from
May 16, 2020

Conversation

chendave
Copy link
Member

@chendave chendave commented Apr 28, 2020 •
edited
Loading

This change also make it possible to score the resources beyond the "cpu"
and "memory" which is currently listed in "defaultRequestedRatioResources".

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #89507

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`NodeResourcesLeastAllocated` and `NodeResourcesMostAllocated` plugins now support customized weight on the CPU and memory.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 28, 2020
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 28, 2020
@chendave
Copy link
Member Author

/test pull-kubernetes-conformance-kind-ga-only-parallel

@chendave
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@alculquicondor
Copy link
Member

Also, please wait for #90309

@alculquicondor alculquicondor mentioned this pull request Apr 28, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Apr 29, 2020
@chendave
Copy link
Member Author

hey @alculquicondor, thanks for your comments!

@chendave
Copy link
Member Author

/hold
waiting for #90309

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2020
@chendave
Copy link
Member Author

/test pull-kubernetes-verify

@chendave
Copy link
Member Author

/test pull-kubernetes-typecheck
/test pull-kubernetes-e2e-gce
/test pull-kubernetes-dependencies

@chendave
Copy link
Member Author

/test pull-kubernetes-e2e-kind

@alculquicondor
Copy link
Member

To make reviews easier, please don't amend your commits.
Once the PR is approved, we will ask you to squash before the final lgtm.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2020
@alculquicondor
Copy link
Member

#90309 was merged

@chendave
Copy link
Member Author

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2020
@chendave
Copy link
Member Author

/test pull-kubernetes-integration
/test pull-kubernetes-conformance-kind-ga-only-parallel

alculquicondor
alculquicondor reviewed May 15, 2020
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

for scheduler

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2020
@chendave
Configurable weight on the CPU and memory
621c73b 
This change also make it possible to score the resources beyond the "cpu"
and "memory" which is currently listed in "defaultRequestedRatioResources".

Signed-off-by: Dave Chen <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2020
alculquicondor
alculquicondor reviewed May 15, 2020
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2020
@liggitt
Copy link
Member

liggitt commented May 15, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, chendave, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@chendave
Copy link
Member Author

/test pull-kubernetes-e2e-kind-ipv6

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@chendave
Copy link
Member Author

/test pull-kubernetes-verify
/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 7f0c05b into kubernetes:master May 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 16, 2020
@github-actions github-actions bot mentioned this pull request May 27, 2020
Closed
@chendave chendave deleted the weight branch February 1, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@liggitt liggitt liggitt left review comments

@resouer resouer Awaiting requested review from resouer

Assignees

@liggitt liggitt

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

weight of Memory and CPU should be configurable
5 participants
@chendave @alculquicondor @fejta-bot @liggitt @k8s-ci-robot