Log ip not hostname. Use quotes for logging

kubernetes · Jul 24, 2020 · 4b04b31 · 4b04b31
1 parent e7058d9
commit 4b04b31
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/minikube/driver/endpoint.go b/pkg/minikube/driver/endpoint.go
@@ -32,7 +32,7 @@ func ControlPlaneEndpoint(cc *config.ClusterConfig, cp *config.Node, driverName
 		hostname := oci.DefaultBindIPV4
 		ip := net.ParseIP(hostname)
 		if ip == nil {
-			return hostname, ip, port, fmt.Errorf("failed to parse ip for %s", hostname)
+			return hostname, ip, port, fmt.Errorf("failed to parse ip for %q", hostname)
 		}
 
 		// https://github.com/kubernetes/minikube/issues/3878
@@ -49,7 +49,7 @@ func ControlPlaneEndpoint(cc *config.ClusterConfig, cp *config.Node, driverName
 	}
 	ip := net.ParseIP(cp.IP)
 	if ip == nil {
-		return hostname, ip, cp.Port, fmt.Errorf("failed to parse ip for %s", hostname)
+		return hostname, ip, cp.Port, fmt.Errorf("failed to parse ip for %q", cp.IP)
 	}
 	return hostname, ip, cp.Port, nil
 }