-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metallb addon: fix configuration empty load balancing IP range #10395
Conversation
Hi @govargo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: govargo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @tstromberg |
Can one of the admins verify this patch? |
/ok-to-test |
kvm2 Driver |
@govargo thank you for fixing this |
What type of PR is this?
/kind bug
/area addons
What this PR does / why we need it:
This PR fixes the bug of
minikube addons configure metallb
.Currently, when users execute
minikube addons configure metallb
first time, the load balancing IP range will be empty.It's because minikube evaluates generate templated file, when
minikube addons enable XXXX
.But, current flows of configuration are
minikube addons enable metallb
- template manifest evaluated with emptyminikube addons configure metallb
- set load balancing IP with emptyThis PR fixes this.
Which issue(s) this PR fixes:
Fix #10307
Does this PR introduce a user-facing change?
Yes. This PR fixes metallb addon.
Before this PR (Load Balancing IPs are empty)
After this PR (Load Balancing IPs are set)
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: