Code

Fixes mount cleaning mechanism#15782

Code

Merged

spowelljr merged 39 commits intokubernetes:masterkubernetes/minikube:masterfrom x7upLime:fix-minikube_mountx7upLime/minikube:fix-minikube_mountCopy head branch name to clipboardApr 26, 2023

+382-32

Commits

Commits on Apr 21, 2023

• Adjusts mount processes cleaning logic

  Show description for 9d4f296
  x7upLime

  committed
  9d4f296

  Copy full SHA for 9d4f296

• Add integration test for mount-clean mechanism

  Show description for 47981b7
  x7upLime

  committed
  47981b7

  Copy full SHA for 47981b7

• Fixes lint error

  Show description for 07f3f44
  x7upLime

  committed
  07f3f44

  Copy full SHA for 07f3f44

• Adds documentation for validateMountCmd test

  Show description for 849de90
  x7upLime

  committed
  849de90

  Copy full SHA for 849de90

• Corrects error handling in killProcess

  Show description for 07d2070
  x7upLime

  committed
  07d2070

  Copy full SHA for 07d2070

• Adds description to lock.AppendToFile

  x7upLime

  committed
  e34548f

  Copy full SHA for e34548f

• Modifies integration test label

  Show description for 70a0ed2
  x7upLime

  committed
  70a0ed2

  Copy full SHA for 70a0ed2

• Modularizes killProcess()

  Show description for 3f47e72
  x7upLime

  committed
  3f47e72

  Copy full SHA for 3f47e72

• Changes klog version and adds it to go.sum

  Show description for 60c3863
  x7upLime

  committed
  60c3863

  Copy full SHA for 60c3863

• Adds unit test for new helper function tryKillOne

  Show description for b1bd26a
  x7upLime

  committed
  b1bd26a

  Copy full SHA for b1bd26a

• Stops govet from complaining

  Show description for e91f041
  x7upLime

  committed
  e91f041

  Copy full SHA for e91f041

• Adds source for cross platform killable process to test

  Show description for badc971
  x7upLime

  committed
  badc971

  Copy full SHA for badc971

• Changes name to unittest tool

  x7upLime

  committed
  ead0b40

  Copy full SHA for ead0b40

• Removes external lib dependency

  Show description for b5d5bbe
  x7upLime

  committed
  b5d5bbe

  Copy full SHA for b5d5bbe

• Refactors GetPids

  Show description for 51e46b6
  x7upLime

  committed
  51e46b6

  Copy full SHA for 51e46b6

• Removes pidfile util

  x7upLime

  committed
  e28a1b4

  Copy full SHA for e28a1b4

• Apply suggestions from code review

  x7upLime

  committed
  ee22b47

  Copy full SHA for ee22b47

• Changes variable name in test

  x7upLime

  committed
  43ff38b

  Copy full SHA for 43ff38b

• Changes variable name in integrataion test

  x7upLime

  committed
  3b3d290

  Copy full SHA for 3b3d290

• Changes helper killProcess function name

  x7upLime

  committed
  db14047

  Copy full SHA for db14047

• Update cmd/minikube/cmd/delete.go

  x7upLime

  committed
  b368c64

  Copy full SHA for b368c64

• Makes comment more clear

  x7upLime

  committed
  1d5b316

  Copy full SHA for 1d5b316

• Renames sigkill function

  x7upLime

  committed
  b5e59b5

  Copy full SHA for b5e59b5

• Ensures sigkilling only minikube started processes

  Show description for ddec310
  x7upLime

  committed
  ddec310

  Copy full SHA for ddec310

• Changes pid owner conditional

  Show description for d72f2fb
  x7upLime

  committed
  d72f2fb

  Copy full SHA for d72f2fb

• Changes the way in which pid is written to mounts file

  Show description for e5b57f8
  x7upLime

  committed
  e5b57f8

  Copy full SHA for e5b57f8

• Generates docs

  x7upLime

  committed
  9665bad

  Copy full SHA for 9665bad

• Adds the ownership check as a dependency

  Show description for c55a4ca
  x7upLime

  committed
  c55a4ca

  Copy full SHA for c55a4ca

• Adapts unit test to new dependency

  x7upLime

  committed
  82abc0d

  Copy full SHA for 82abc0d

• Adapts TestTryKillOne log for failing

  x7upLime

  committed
  595c8ee

  Copy full SHA for 595c8ee

• Corrects mendacious comment

  x7upLime

  committed
  8f50ee9

  Copy full SHA for 8f50ee9

• Regenerates docs

  x7upLime

  committed
  1398988

  Copy full SHA for 1398988

• Corrects style issue

  x7upLime

  committed
  b09cd43

  Copy full SHA for b09cd43

• Saves us from passing func as parameter

  Show description for 0170981
  x7upLime

  committed
  0170981

  Copy full SHA for 0170981

• Apply suggestions from code review

  x7upLime

  committed
  b196ee4

  Copy full SHA for b196ee4

• added stuff to reflect suggestions

  x7upLime

  committed
  3d3e6a1

  Copy full SHA for 3d3e6a1

• Adds mechanism to remove pid from pidfile if mount is sigtermd

  x7upLime

  committed
  aab0cb6

  Copy full SHA for aab0cb6

Commits on Apr 22, 2023

• refactors removePid logic

  x7upLime

  committed
  455bcb1

  Copy full SHA for 455bcb1

Commits on Apr 25, 2023

• Applied suggestions

  x7upLime

  committed
  8931619

  Copy full SHA for 8931619