Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prow job blacklist #15856

Closed
Katharine opened this issue Jan 10, 2020 · 6 comments
Closed

Add a prow job blacklist #15856

Katharine opened this issue Jan 10, 2020 · 6 comments
Labels
area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Katharine
Copy link
Member

Sometimes I would like to be able to disable a bunch of prowjobs for infrastructure reasons (e.g. #15854). However, while finding the jobs may be relatively easy, actually disabling the jobs is difficult, because it requires editing large numbers of jobs, which may then fail tests because they're auto-generated, etc. Undoing the change may then also be a pain.

It would be easier to be able to just edit a list of jobs that prow should refuse to start under any circumstances.

/area prow

@Katharine Katharine added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Jan 10, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2020
@BenTheElder
Copy link
Member

@cjwagner thoughts?

@cjwagner
Copy link
Member

cjwagner commented May 1, 2020

Is the only benefit of this that we can disable periodic jobs without losing the history of when the last run was? Deleting jobs from config seems equally as difficult as declaring a blacklist.

@BenTheElder
Copy link
Member

BenTheElder commented May 1, 2020 via email

@cjwagner
Copy link
Member

cjwagner commented May 1, 2020

Thats fair, but it still seems like it would be pretty easy to just delete all the shards? I don't change job config as much or at as large a scale as you or Katharine so I haven't really run into this pain point myself.

We could add a blacklist to the Prow config and make Tide, Horologium, and the trigger plugin respect it, but I'm wondering how helpful this would actually be so we can prioritize it against other work.

@BenTheElder
Copy link
Member

I haven't actually needed this recently, and i'm not sure how much it would have helped in the past.

let's close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants