Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary janitor zone hack. #15951

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Temporary janitor zone hack. #15951

merged 1 commit into from
Jan 17, 2020

Conversation

Katharine
Copy link
Member

Try to get the janitors running again.

/cc @fejta @cjwagner @ixdy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 17, 2020
cjwagner
cjwagner approved these changes Jan 17, 2020
View reviewed changes
boskos/janitor/gcp_janitor.py
@@ -14,6 +14,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# I am not dealing with this today.
# pylint: disable=line-too-long
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6384054 into kubernetes:master Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 17, 2020
Katharine added a commit to Katharine/test-infra that referenced this pull request Jan 21, 2020
@Katharine
Revert "Merge pull request kubernetes#15951 from Katharine/janitor-zo…
b499070 
…ne-hack"

This reverts commit 6384054, reversing
changes made to 3029825.
k8s-ci-robot added a commit that referenced this pull request Jan 21, 2020
@k8s-ci-robot
Merge pull request #15974 from Katharine/remove-janitor-zone-hack
9a9eed6 
Revert "Merge pull request #15951 from Katharine/janitor-zone-hack"
@bobcatfish bobcatfish mentioned this pull request Jan 21, 2020
Closed
@lukasschwab lukasschwab mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner approved these changes

@fejta fejta Awaiting requested review from fejta

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@Katharine @k8s-ci-robot @cjwagner