Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tekton Pipeline version to latest #26648

Conversation

qaifshaikh
Copy link

Bump Tekton Pipelines to v0.36.0

Created in response for the issue: #26535

CONTEXT:

  • We have been able to integrate Tekton Pipelines with our Prow setup quite smoothly.
    • I'm hoping to contribute some docs soon that will help people achieve the same
  • But unfortunately prow only supports the tekton pipelines up to v0.14.0 while the recent one is v0.36.0 which is very outdated.
  • We don't even have the support for v1beta1 yet which has been available since 2019
  • We're looking forward to a bunch of new features that tekton pipelines packs with its newer versions.

Some features we really need from the recent versions are:

  • Ability to use volumeClaimTemplates
  • Building pipelines with shared workspaces
  • Parallelizing tasks with pipelines to use the same pre-requisites for all jobs for a specific PULL_SHA
  • And lots more covered in every release betweenv0.14.0 to v0.36.0
    https://github.com/tektoncd/pipeline/releases

More Context: #26537

Next steps:

  1. Generate v1beta1 client
  2. Add v1beta1 support

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @qaifshaikh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qaifshaikh
To complete the pull request process, please assign fejta after the PR has been reviewed.
You can assign the PR to them by writing /assign @fejta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added area/prow/peribolos Issues or PRs related to prow's peribolos component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 21, 2022
@qaifshaikh
Copy link
Author

cc @eddycharly @cjwagner

@qaifshaikh
Copy link
Author

I'm currently working generating the v1beta1 client for tekton pipelines which will be my next PR

@eddycharly
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2022
@qaifshaikh
Copy link
Author

qaifshaikh commented Jun 22, 2022

Looks like the most common error is coming from upgrading logr packages 🤔

github.com/go-logr/logr v1.2.2 // indirect
github.com/go-logr/zapr v1.2.0 // indirect

Update:
Yes seems like it: kubernetes-sigs/controller-runtime#1726 (comment)

@qaifshaikh
Copy link
Author

I guess all the packages are being updated mostly because I updated k8s.io/client-go from v0.22.2 to v0.23.5

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/prow/deck Issues or PRs related to prow's deck component area/prow/hook Issues or PRs related to prow's hook component area/prow/sinker Issues or PRs related to prow's sinker component area/prow/tide Issues or PRs related to prow's tide component and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

@qaifshaikh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-prow-image-build-test 48ef9ad link true /test pull-test-infra-prow-image-build-test
pull-test-infra-unit-test 48ef9ad link true /test pull-test-infra-unit-test
pull-test-infra-integration 48ef9ad link true /test pull-test-infra-integration
pull-test-infra-verify-lint 48ef9ad link true /test pull-test-infra-verify-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

@qaifshaikh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2022
@olemarkus
Copy link
Member

I didn't realize a PR already exised. But I have #26762 and it's passing the tests.
I resolved the deps issues in an earlier PR.

@qaifshaikh qaifshaikh closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow/deck Issues or PRs related to prow's deck component area/prow/hook Issues or PRs related to prow's hook component area/prow/peribolos Issues or PRs related to prow's peribolos component area/prow/sinker Issues or PRs related to prow's sinker component area/prow/tide Issues or PRs related to prow's tide component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants