Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tekton v1beta1 support #27034

Merged
merged 6 commits into from
Jan 11, 2023
Merged

feat: add tekton v1beta1 support #27034

merged 6 commits into from
Jan 11, 2023

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Aug 4, 2022 •
edited
Loading

This PR adds tekton v1beta1 support (side by side with v1alpha1).

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 4, 2022
@eddycharly eddycharly mentioned this pull request Aug 4, 2022
Closed
@eddycharly eddycharly force-pushed the tkn-beta branch 3 times, most recently from 79c5a0a to b367996 Compare August 4, 2022 15:57
@eddycharly eddycharly changed the title feat: support multiple tekton pipeline versions feat: use a dedicated field for tekton pipeline v1alpha1 Aug 4, 2022
@eddycharly
Copy link
Member Author

eddycharly commented Aug 4, 2022 •
edited
Loading

/hold
/cc @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2022
@eddycharly eddycharly marked this pull request as ready for review August 4, 2022 16:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from chases2 August 4, 2022 16:02
@eddycharly eddycharly marked this pull request as draft August 4, 2022 17:55
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2022
@eddycharly eddycharly changed the title feat: use a dedicated field for tekton pipeline v1alpha1 feat: add tekton v1beta1 support Aug 4, 2022
@eddycharly eddycharly marked this pull request as ready for review August 4, 2022 18:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from chaodaiG August 4, 2022 18:30
@eddycharly eddycharly force-pushed the tkn-beta branch 2 times, most recently from 00ce691 to 58eda54 Compare August 4, 2022 19:20
@BenTheElder BenTheElder mentioned this pull request Jan 4, 2023
Closed
@qaifshaikh
Copy link

/lgtm
this should simplify the v1 upgrades as well. Really appreciate this!

@k8s-ci-robot
Copy link
Contributor

@qaifshaikh: changing LGTM is restricted to collaborators

In response to this:

/lgtm
this should simplify the v1 upgrades as well. Really appreciate this!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michelle192837
Copy link
Contributor

/cc @stevekuznetsov @alvaroaleman @chaodaiG

@k8s-ci-robot
Copy link
Contributor

@michelle192837: GitHub didn't allow me to request PR reviews from the following users: alvaroaleman, chaodaiG, stevekuznetsov.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @stevekuznetsov @alvaroaleman @chaodaiG

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaodaiG
Copy link
Contributor

chaodaiG commented Jan 5, 2023

/cc cjwagner listx

@k8s-ci-robot
Copy link
Contributor

@chaodaiG: GitHub didn't allow me to request PR reviews from the following users: cjwagner, listx.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc cjwagner listx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michelle192837
Copy link
Contributor

/cc michelle192837

@k8s-ci-robot
Copy link
Contributor

@michelle192837: GitHub didn't allow me to request PR reviews from the following users: michelle192837.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc michelle192837

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michelle192837
Copy link
Contributor

/assign michelle192837

@petr-muller
Copy link
Member

/cc

@k8s-ci-robot
Copy link
Contributor

@petr-muller: GitHub didn't allow me to request PR reviews from the following users: petr-muller.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov
stevekuznetsov approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
for any other 👀

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddycharly, qaifshaikh, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2023
@qaifshaikh
Copy link

Are we waiting for reviews from @michelle192837 and @cjwagner ?
Would be nice to merge this soon since we have to do more work on the newer tekton pipeline version upgrades!

@michelle192837
Copy link
Contributor

Don't wait up on me for review, I'm just investigating as oncall 😅

speaking of:

/cc michelle192837

@k8s-ci-robot
Copy link
Contributor

@michelle192837: GitHub didn't allow me to request PR reviews from the following users: michelle192837.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Don't wait up on me for review, I'm just investigating as oncall 😅

speaking of:

/cc michelle192837

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eddycharly
Copy link
Member Author

Ok, I will remove the hold tomorrow if no one steps in until then 🤞

@eddycharly
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit cd1b3ca into kubernetes:master Jan 11, 2023
@eddycharly eddycharly deleted the tkn-beta branch January 11, 2023 14:29
@michelle192837 michelle192837 removed their assignment Jan 23, 2023
@michelle192837
Copy link
Contributor

Sorry, last bit of spam.

/cc @michelle192837

@k8s-ci-robot
Copy link
Contributor

@michelle192837: GitHub didn't allow me to request PR reviews from the following users: michelle192837.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Sorry, last bit of spam.

/cc @michelle192837

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@qaifshaikh qaifshaikh Awaiting requested review from qaifshaikh

Assignees

@cjwagner cjwagner

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.