Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom-metrics-apiserver to go 1.20 #29384

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Update custom-metrics-apiserver to go 1.20 #29384

merged 1 commit into from
Apr 28, 2023

Conversation

dgrisonnet
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2023
@dgrisonnet
Copy link
Member Author

/assign @olivierlemasle

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs labels Apr 28, 2023
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 28, 2023
olivierlemasle
olivierlemasle approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@olivierlemasle olivierlemasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @dgrisonnet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, olivierlemasle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 98c831b into kubernetes:master Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

@dgrisonnet: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key custom-metrics-apiserver-presubmits.yaml using file config/jobs/kubernetes-sigs/custom-metrics-apiserver/custom-metrics-apiserver-presubmits.yaml

In response to this:

Required by kubernetes-sigs/custom-metrics-apiserver#151.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet dgrisonnet mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierlemasle olivierlemasle olivierlemasle approved these changes

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@olivierlemasle olivierlemasle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgrisonnet @k8s-ci-robot @olivierlemasle