-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore EventedPLEG for WIP bugfix PR #31647
Conversation
/cc @p0lyn0mial @harche @aojea |
@pacoxu I brought this up in today's sig-node CI meeting. Feedback was to add a comment somewhere near the change explaining why we are skipping the feature. I think maybe adding a link to the backing issue, kubernetes/kubernetes#122721 also might be a good idea. |
yes please, add a comment , if this is a SIG Node decision is ok, but we should not forget to fix this, during next release we should figure out what are we going to do with this feature Thanks |
1acb901
to
bea118b
Compare
Comments are added. We should fix it in v1.30. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pacoxu: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks! |
So we don't block other alpha feature PR running those CI.
See kubernetes/kubernetes#122721 (comment)
In https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gce-cos-alpha-features,
we can see some PR want to run those alpha features CI, and now failed for kubernetes/kubernetes#122721.