Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore EventedPLEG for WIP bugfix PR #31647

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 17, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Jan 17, 2024

/cc @p0lyn0mial @harche @aojea
/assign @dims

@harche
Copy link
Contributor

harche commented Jan 17, 2024

@pacoxu I brought this up in today's sig-node CI meeting. Feedback was to add a comment somewhere near the change explaining why we are skipping the feature. I think maybe adding a link to the backing issue, kubernetes/kubernetes#122721 also might be a good idea.

@aojea
Copy link
Member

aojea commented Jan 17, 2024

@pacoxu I brought this up in today's sig-node CI meeting. Feedback was to add a comment somewhere near the change explaining why we are skipping the feature. I think maybe adding a link to the backing issue, kubernetes/kubernetes#122721 also might be a good idea.

yes please, add a comment , if this is a SIG Node decision is ok, but we should not forget to fix this, during next release we should figure out what are we going to do with this feature

Thanks

@pacoxu pacoxu force-pushed the EventedPLEG-false branch from 1acb901 to bea118b Compare January 17, 2024 21:59
@pacoxu
Copy link
Member Author

pacoxu commented Jan 17, 2024

Comments are added.

We should fix it in v1.30.

@aojea
Copy link
Member

aojea commented Jan 17, 2024

/lgtm
/approve

Thanks @pacoxu and @harche and other for working so hard on this, not the better outcome expected but at least we have a path forward, thanks again

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9cd9685 into kubernetes:master Jan 17, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@pacoxu: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key kubernetes-kind.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml

In response to this:

So we don't block other alpha feature PR running those CI.

See kubernetes/kubernetes#122721 (comment)

In https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gce-cos-alpha-features,
we can see some PR want to run those alpha features CI, and now failed for kubernetes/kubernetes#122721.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants